Multiple priv dns zones #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urce for the shared container registry instance
…e for every region/cluster
ckittel
requested changes
Jan 31, 2022
There was a problem hiding this comment.
Missing a small narrative update on https://github.com/mspnp/aks-baseline-multi-region/blob/main/docs/deploy/03-cluster-prerequisites.md#expected-results where it implies you are deploying something that you no longer are.
Other than that, no other changes suggested. Nice.
Please review the matching content on docs.microsoft.com to see if there needs to be any updates to that, and I'll add it to the CD queue. Let me know on teams for this part.
|
Tested using pull mechanism set to Always. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46