Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the AKS baseline's "saveenv.sh" feature #55

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Introduce the AKS baseline's "saveenv.sh" feature #55

merged 4 commits into from
Sep 12, 2022

Conversation

ckittel
Copy link
Member

@ckittel ckittel commented Sep 12, 2022

  • Started adding the feature, only got the first couple of pages covered, got through the GitHub username and Azure AD pages.
  • Also added one callout that we have in the AKS baseline around skipping a log in if needed

@ckittel ckittel requested a review from skabou September 12, 2022 16:38
Copy link
Contributor

@skabou skabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't get the script to work. Are there extra steps?
I am able to see my variable with 'set' but not with 'env' or 'export'

Requesting a Cloud Shell.Succeeded.
Connecting terminal...

jason@Azure:$ cd aks
jason@Azure:
/aks$ GITHUB_USER_NAME_AKS_MRB=$(echo $(gh auth status 2>&1) | sed "s#.as (.) (.*#\1#")
jason@Azure:/aks$ echo $GITHUB_USER_NAME_AKS_MRB
skabou
jason@Azure:
/aks$ env | grep GITHUB_USER_NAME_AKS_MRB
jason@Azure:/aks$ set | grep GITHUB_USER_NAME_AKS_MRB
GITHUB_USER_NAME_AKS_MRB=skabou
jason@Azure:
/aks$ ./saveenv.sh
#!/bin/bash

jason@Azure:~/aks$ cat aks_baseline.env
#!/bin/bash

jason@Azure:~/aks$

@ckittel
Copy link
Member Author

ckittel commented Sep 12, 2022

Shoot, I missed a commit. Thanks! One moment please

@ckittel
Copy link
Member Author

ckittel commented Sep 12, 2022

I can't get the script to work. Are there extra steps? I am able to see my variable with 'set' but not with 'env' or 'export'

Addressed in e910c46 -- and also added the missing .gitignore changes.

Copy link
Contributor

@skabou skabou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! 🚢

@ckittel ckittel merged commit 310b94d into main Sep 12, 2022
@ckittel ckittel deleted the save-env branch September 12, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants