Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSS Update Pass + Style Changes #362

Merged
merged 10 commits into from
Jan 3, 2023
Merged

OSS Update Pass + Style Changes #362

merged 10 commits into from
Jan 3, 2023

Conversation

ckittel
Copy link
Member

@ckittel ckittel commented Dec 29, 2022 •
edited

  • Updated kured to latest version (1.11.0 -> 1.12.0) and synced yaml manifests with upstream
  • Updated traefik to latest version (2.8.1 -> 2.96) and synced yaml manifests with upstream
  • Updated Azure Monitor's configuration with latest
  • Enabled notification controller on Flux extension to avoid nasty error messages in logs :(
  • Minor style updates throughout the walkthrough
  • Fixed walkthrough bug that still had kured coming from dockerhub instead of ghcr.
  • Fixed a permissions issue bug with kured (previously had n-kured instead of kured in the role definition)

This was tested end-to-end.

@ckittel
Copy link
Member Author

ckittel commented Dec 30, 2022

Thanks for the review, @v-fearam. I'll wait for a review from @ferantivero as well. More 👀, more 🔍.

ferantivero
ferantivero approved these changes Jan 3, 2023
View reviewed changes
Copy link
Contributor

@ferantivero ferantivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely done @ckittel, LGTM 🚢

only one quick question as part of this review.

cluster-manifests/kube-system/container-azm-ms-agentconfig.yaml Outdated Show resolved Hide resolved
@ckittel ckittel merged commit ef75c5e into main Jan 3, 2023
@ckittel ckittel deleted the jan-update branch January 3, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferantivero ferantivero ferantivero approved these changes

@v-fearam v-fearam v-fearam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ckittel @ferantivero @v-fearam