Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate event related extractors to EventExtractor #116

Open
5 of 6 tasks
fabiodrg opened this issue Mar 30, 2022 · 1 comment
Open
5 of 6 tasks

Migrate event related extractors to EventExtractor #116

fabiodrg opened this issue Mar 30, 2022 · 1 comment
Labels
blocked Issue cannot be solved for some reason, e.g., depends on another issue code quality Issues related to improve code quality extractor Extractor related issues
Projects
v4.3 v4.4

Comments

@fabiodrg
Copy link
Collaborator

fabiodrg commented Mar 30, 2022 •
edited

  • Bills
  • Exams
  • Library
  • Single exam
  • Timetable
  • Exam supervisions
@fabiodrg fabiodrg added extractor Extractor related issues code quality Issues related to improve code quality labels Mar 30, 2022
@fabiodrg fabiodrg changed the title Migrate event related extractros to EventExtractor Migrate event related extractors to EventExtractor Apr 1, 2022
fabiodrg added a commit that referenced this issue Apr 2, 2022
@fabiodrg
refactor(extractor/bills): Use 'EventExtractor' (#116). Replace inline
0853144 
dropdowns with modal for events.
fabiodrg added a commit that referenced this issue Apr 2, 2022
@fabiodrg
refactor(extractor/bills): Use 'EventExtractor' (#116). Replace inline
0f4a4a5 
dropdowns with modal for events.
@fabiodrg fabiodrg linked a pull request Apr 2, 2022 that will close this issue
Enhance the bills extractor #118
Merged
@fabiodrg fabiodrg removed a link to a pull request Apr 2, 2022
Enhance the bills extractor #118
Merged
@fabiodrg fabiodrg added this to In progress in v4.3 Apr 26, 2022
fabiodrg added a commit that referenced this issue May 1, 2022
@fabiodrg
refactor(SingleExam): Extend EventExtractor class (#116)
0b6f5b4 
- Makes the class an instance of `EventExtractor` as part of the
  overhaul refactoring
- Fixes the parsing of exam type, i.e., Mini Testes, Recursos, etc.
@fabiodrg fabiodrg mentioned this issue May 2, 2022
Merged
fabiodrg added a commit that referenced this issue May 4, 2022
@fabiodrg
refactor(Extractor/Exams): Use EventExtractor and fix group by exam
83e314e 
type

- Refactors the extractor to use `EventExtractor` (#116)
- Fixes an issue where the exams were not correctly grouped by type. The
  parsing was not right, as the Sigarra page has changed. Moreover, this
commit takes an approach that should work for any kind of exam type in
the page, extending the support beyond "epoca normal" and "epoca
recurso"
fabiodrg added a commit that referenced this issue May 4, 2022
@fabiodrg
refactor(Extractor/Timetable): Use EventExtractor (#116)
b386a79
fabiodrg added a commit that referenced this issue May 4, 2022
@fabiodrg
refactor(Extractor/Timetable): Use EventExtractor (#116)
5e3bf00
@fabiodrg
Copy link
Collaborator Author

I don't have a way to test the library extractor at this moment

@fabiodrg fabiodrg added the blocked Issue cannot be solved for some reason, e.g., depends on another issue label Jul 24, 2022
@fabiodrg fabiodrg moved this from In progress to Done in v4.3 Jul 24, 2022
@fabiodrg fabiodrg added this to To do in v4.4 Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked Issue cannot be solved for some reason, e.g., depends on another issue code quality Issues related to improve code quality extractor Extractor related issues
Projects
v4.3
  
Done
v4.4
To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fabiodrg