Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lack of event's location #48

Closed
fabiodrg opened this issue Feb 2, 2019 · 3 comments · Fixed by #114
Closed

Add support for lack of event's location #48

fabiodrg opened this issue Feb 2, 2019 · 3 comments · Fixed by #114
Labels
enhancement New feature or request good first issue Good for newcomers
Projects

Comments

@fabiodrg
Copy link
Collaborator

fabiodrg commented Feb 2, 2019

Not sure, but I think all extractors in Sigarra have some sort of location, typically a classroom. However, that assumption isn't verified in Moodle, and as a workaround the current location is Moodle. Would be nice to handle this more properly.

The Google Calendars link and Outlook don't require the location parameter. The standard for ICS almost sure it doesn't require it either, although not sure if the library we are using has limitations.

@fabiodrg fabiodrg added enhancement New feature or request good first issue Good for newcomers labels Feb 2, 2019
@msramalho
Copy link
Owner

I don't think it has that limitation. In any case, one could always change it to "".

I believe I left it as "Moodle" in lack of something more informative as, for instance, some events are like homework on moodle, exam on moodle, delivery on moodle, ...

@fabiodrg
Copy link
Collaborator Author

fabiodrg commented Feb 3, 2019

Ok, that makes some sense. Maybe this could be a setting in the options page?

@msramalho
Copy link
Owner

Agreed, and that should be straightforward to implement!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
v4.2
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants