Break loops when result can no longer change (uber#728)

(Code cleanup/optimization)
msridhar · Feb 7, 2023 · a2efa6e · a2efa6e
1 parent de6e014
commit a2efa6e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPathNullnessAnalysis.java b/nullaway/src/main/java/com/uber/nullaway/dataflow/AccessPathNullnessAnalysis.java
@@ -231,6 +231,7 @@ public NullnessStore getNullnessInfoBeforeNewContext(
             if (!e.getKind().equals(ElementKind.FIELD)
                 || !e.getModifiers().contains(Modifier.FINAL)) {
               allAPNonRootElementsAreFinalFields = false;
+              break;
             }
           }
           if (allAPNonRootElementsAreFinalFields) {

diff --git a/nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java b/nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java
@@ -208,6 +208,7 @@ public NullnessHint onDataflowVisitMethodInvocation(
       for (int idx : nullImpliesNullIndexes) {
         if (!inputs.valueOfSubNode(node.getArgument(idx)).equals(NONNULL)) {
           anyNull = true;
+          break;
         }
       }
       return anyNull ? NullnessHint.HINT_NULLABLE : NullnessHint.FORCE_NONNULL;