Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries added in the app won't be deleted, when deleted outside #60

Closed
nielsk opened this issue Mar 13, 2017 · 5 comments
Closed

Entries added in the app won't be deleted, when deleted outside #60

nielsk opened this issue Mar 13, 2017 · 5 comments
Labels

Comments

@nielsk
Copy link

nielsk commented Mar 13, 2017

Create a new entry in the app and sync to your repo
Now on your computer delete or move the entry, sync again with git
Sync with the app and the entry still exists. In the case of a move to a folder, the entry will also exist in the folder now (so now you have it twice).

But syncing to the repo won't add the local entry again to the repo until you change something in the local entry.

@yishilin14
Copy link
Collaborator

yishilin14 commented Mar 13, 2017

Thanks for your report. It seems like the logic of file organization is not robust.

@yishilin14 yishilin14 added the bug label Mar 13, 2017
yishilin14 added a commit that referenced this issue Mar 15, 2017
- fix the logic for "git add" and "git commit"
- update the logic for "git remove" (useless function, not tested yet)
@yishilin14
Copy link
Collaborator

Fixed. The bug is triggered by flawed "git add/commit" implementation.

@nielsk
Copy link
Author

nielsk commented Mar 18, 2017

works for me now as well

@nielsk
Copy link
Author

nielsk commented Mar 18, 2017

Beware: when you created before this bug was fixed an entry and moved it on another computer via git mv; and do now a git pull on the other computer the entry will be deleted.
You have to edit the entry on the iOS-client and sync. Then sync on the computer. Then it gets pulled again. Then move it (pass mv bar foo/bar), sync again and then sync the iOS-client. Then the entry will be at the correct position again.
Luckily I created only a few entries on the iOS-client so far because that part is/was so buggy.

@yishilin14
Copy link
Collaborator

I am so sorry for the inconvenience.

We are trying our best to polish the logic, and we are short of hands now. To avoid similar problems, we suggest that you make sure that your repo looks like what you want at any time. For example, by syncing your updates timely. In case you feel that some bugs will probably mess up your repo, you may erase everything and clone a clean repo again.

Thank you so much for your patience and valuable reports!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants