Add patch for stakingrewards (#111)

mstable · Oct 9, 2020 · 2722417 · 2722417
1 parent 816b2a6
commit 2722417
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 0 deletions.
diff --git a/contracts/rewards/staking/StakingRewards.sol b/contracts/rewards/staking/StakingRewards.sol
@@ -238,6 +238,8 @@ contract StakingRewards is StakingTokenWrapper, RewardsDistributionRecipient {
         onlyRewardsDistributor
         updateReward(address(0))
     {
+        require(_reward < 1e24, "Cannot notify with more than a million units");
+
         uint256 currentTime = block.timestamp;
         // If previous period over, reset rewardRate
         if (currentTime >= periodFinish) {

diff --git a/contracts/rewards/staking/StakingRewardsWithPlatformToken.sol b/contracts/rewards/staking/StakingRewardsWithPlatformToken.sol
@@ -295,6 +295,8 @@ contract StakingRewardsWithPlatformToken is StakingTokenWrapper, RewardsDistribu
         onlyRewardsDistributor
         updateReward(address(0))
     {
+        require(_reward < 1e24, "Cannot notify with more than a million units");
+
         uint256 newPlatformRewards = platformToken.balanceOf(address(this));
         if(newPlatformRewards > 0){
             platformToken.safeTransfer(address(platformTokenVendor), newPlatformRewards);

diff --git a/test/rewards/TestStakingRewards.spec.ts b/test/rewards/TestStakingRewards.spec.ts
@@ -374,6 +374,19 @@ contract("StakingRewards", async (accounts) => {
             });
         });
     });
+    context("funding with too much rewards", () => {
+        before(async () => {
+            stakingRewards = await redeployRewards();
+        });
+        it("should fail", async () => {
+            await expectRevert(
+                stakingRewards.notifyRewardAmount(simpleToExactAmount(1, 25), {
+                    from: sa.fundManager,
+                }),
+                "Cannot notify with more than a million units",
+            );
+        });
+    });
     context("staking before rewards are added", () => {
         before(async () => {
             stakingRewards = await redeployRewards();

diff --git a/test/rewards/TestStakingRewardsWithPlatformToken.spec.ts b/test/rewards/TestStakingRewardsWithPlatformToken.spec.ts
@@ -509,6 +509,20 @@ contract("StakingRewardsWithPlatformToken", async (accounts) => {
             });
         });
     });
+
+    context("funding with too much rewards", () => {
+        before(async () => {
+            stakingRewards = await redeployRewards();
+        });
+        it("should fail", async () => {
+            await expectRevert(
+                stakingRewards.notifyRewardAmount(simpleToExactAmount(1, 25), {
+                    from: sa.fundManager,
+                }),
+                "Cannot notify with more than a million units",
+            );
+        });
+    });
     context("staking before rewards are added", () => {
         before(async () => {
             stakingRewards = await redeployRewards();