Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pool Together changes #185

Merged
merged 10 commits into from Jun 29, 2021
Merged

Pool Together changes #185

merged 10 commits into from Jun 29, 2021

Conversation

naddison36
Copy link
Contributor

@naddison36 naddison36 commented Jun 25, 2021

Changes so mStable contracts and functions can be imported into external repos. eg pooltogether-mstable

  • Added underlying() function to ISavingsContractV2 interface used by the PoolTogether yield source contract
  • Updated from legacy hardhat-typechain to @typechain/hardhat
  • Upgraded to latest dependencies including ethers, typechain, hardhat and typescript
  • Export functions and types from the package
  • Added type definitions to TS config
  • moved typescript output from transpiled to dist and added to repo and published package
  • Fixed bug in deployMV3 task that was causing type errors with new Typechain version
  • Token interface renamed optional savings to vault and added optional saving
  • Added rewards task to get COMP and stkAAVE stats

Copy link
Contributor

@alsco77 alsco77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solidity looks good

Can you give me a TLDR of the purpose of the dist folder here? If it is for cross repo sharing, we should just run a command during the prepublishOnly script that will add the necessary resources to the dist folder before publish, and this way we can avoid having to commit them to the repo. Should then add to the gitignore IMO so we dont get this bloat during PRs.

What do you think?

feat: Savings Contract interface changes for PoolTogether yield source
feat: Added `rewards` task to get `COMP` and `stkAAVE` stats
chore: Bumped dependencies
@naddison36
Copy link
Contributor Author

Adding the dist folder was a temporary measure on this branch as I didn't want to publish untested changes to the @mstable/protocol npm package.
Now that version 2.2.0 has been published, I've removed the dist and abis folders from the repo as these are now in the npm package.

@alsco77 alsco77 merged commit 89925a8 into master-v2 Jun 29, 2021
@alsco77 alsco77 deleted the pool-together branch June 29, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants