New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pool Together changes #185
Conversation
2a95259
to
1fb3e71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solidity looks good
Can you give me a TLDR of the purpose of the dist folder here? If it is for cross repo sharing, we should just run a command during the prepublishOnly
script that will add the necessary resources to the dist folder before publish, and this way we can avoid having to commit them to the repo. Should then add to the gitignore IMO so we dont get this bloat during PRs.
What do you think?
feat: Savings Contract interface changes for PoolTogether yield source feat: Added `rewards` task to get `COMP` and `stkAAVE` stats chore: Bumped dependencies
45d91d4
to
cdadaf7
Compare
Adding the |
Changes so mStable contracts and functions can be imported into external repos. eg
pooltogether-mstable
underlying()
function toISavingsContractV2
interface used by the PoolTogether yield source contracthardhat-typechain
to@typechain/hardhat
transpiled
todist
and added to repo and published packagedeployMV3
task that was causing type errors with new Typechain versionToken
interface renamed optionalsavings
tovault
and added optionalsaving
rewards
task to getCOMP
andstkAAVE
stats