Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alchemix Integration #192

Merged
merged 21 commits into from
Jul 13, 2021
Merged

Add Alchemix Integration #192

merged 21 commits into from
Jul 13, 2021

Conversation

alsco77
Copy link
Contributor

@alsco77 alsco77 commented Jul 8, 2021

Notes

  • Add AlchemixIntegration contract
  • Add fork tests for alUSD FP

Checklist

  • Fix failing CI
  • Deploy new vault
  • AS verify deployment (0x0997dDdc038c8A958a3A3d00425C16f8ECa87deb)
    • ProxyAdmin
    • Storage
    • Code
  • Updated gitbook/etherscan/etc
  • Fund with small amount of MTA
  • App staging deploy
  • Migrated funds to PlatformIntegration
  • Finalise fork tests
  • Liquidator
    • Add unit tests for ALCX coverage
    • Complete fork tests for liquidator
      • regression of COMP and stkAAVE
  • Beta testing
    • mint (watch deposit into stakingpool)
    • redeem (withdrawal from stakingpool)
    • claimRewards
    • deposit to vault
    • claim from vault
  • App main deploy & funding
  • Release new @mstable/protocol

@naddison36 naddison36 force-pushed the feature/alchemix-integration branch from d40467f to ade52eb Compare July 9, 2021 12:04
JamesLefrere and others added 3 commits July 10, 2021 02:13
- Add `AlchemixIntegration` contract
- Add fork tests for alUSD FP
@naddison36 naddison36 force-pushed the feature/alchemix-integration branch from ade52eb to 336dee6 Compare July 9, 2021 16:15
Copy link
Contributor Author

@alsco77 alsco77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notes occurred during review:

  • Funding the vault critical for beta testing (should do this asap)
  • Some inconsistencies in structure/formatting between this and other integrations. e.g constructor args (rewardsToken before platform address could cause some unintended mistake), var naming (platform vs stakingPools), missing bAssetToPToken & event (unused, but may be needed for front end)
  • Unused rewardsClaimed event

@alsco77 alsco77 changed the title WIP: Add Alchemix Integration Add Alchemix Integration Jul 12, 2021
@alsco77 alsco77 merged commit 4041af6 into master-v2 Jul 13, 2021
@alsco77 alsco77 deleted the feature/alchemix-integration branch July 13, 2021 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants