Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Department becomes organization on save #317

Closed
mstilkerich opened this issue Nov 15, 2020 · 1 comment
Closed

Department becomes organization on save #317

mstilkerich opened this issue Nov 15, 2020 · 1 comment
Assignees
Labels
Milestone

Comments

@mstilkerich
Copy link
Owner

Roundcube has two separate fields for organization and department. In The VCard, the corresponding ORG property is a structured item that can have any number of components, reflecting organization structure.

We use the first part of the ORG property to correspond with organization, and the remaining ones for department (they are concatenated with "; " to form a single value for roundcube).

Now if a contact is saved where the department is specified, but no organization, the department would end up as the first part of the ORG property. When reading back this VCard, it would be shown as organization instead, not as department anymore.

Fix: In this case, store an empty first part in ORG and add the department at the proper position.

@mstilkerich mstilkerich self-assigned this Nov 15, 2020
@mstilkerich mstilkerich added this to the 4.1.0 milestone Nov 15, 2020
mstilkerich added a commit that referenced this issue Nov 15, 2020
The ORG property of a VCard is structured to reflect an organization and
a hierarchical structure of departments.

Example:
ORG:Company;Division;Department;Group

In roundcube, we only have organization and department as two single
value entries.

Now the above is converted such:
organization: Company
department: Division; Department; Group

The inverse way works as well, where different department levels are
separated by semicolon and optional surrounding whitespace in the
roundcube value.

Furthermore, we remove the handling of department given as an array in
save_data, because roundcube always passes a simple string value only,
and so now das RCMCardDAV.
@mstilkerich
Copy link
Owner Author

Fixed in v4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant