Some attributes cannot be deleted by editing contact in roundcube

[mstilkerich]

For unset attributes, roundcube either provides us we an empty value or no entry at all in the given $save_data array. This seems to somewhat depend on whether an attribute is shown in the edit mask or not.

Currently, when saving a value a property will only be removed from the VCard if an empty string is given by roundcube for single-value properties. If no value is given at all, the previous value will be retained. This results in the problem that some attributes can not be deleted from roundcube, for example spouse, by using the delete button. As a workaround, it is possible to not delete the attribute in the edit mask but store an empty value instead, but this is highly non-intuitive for the user.

[mstilkerich]

Note that PHOTO is special: Roundcube will

• give no value (photo key not set in $save_data) in case the photo was left unchanged
• give a value as binary string if the photo was set/changed
• give an empty string as value if the photo was deleted

[mstilkerich]

Fixed on 4.1