Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please implement support of IM fields #46

Closed
bitbybit opened this issue Jun 18, 2014 · 9 comments
Closed

Please implement support of IM fields #46

bitbybit opened this issue Jun 18, 2014 · 9 comments
Milestone

Comments

@bitbybit
Copy link

Hi
Currently carddav plugin does not show IM data (Jabber, ICQ, ...) in "Contact properties" for contacts that already have such fields. And there is no "IM" option under "Add field..." menu in "Add new contact" while in default adressbook "Personal Addresses" we can add IM fields.

@blind-coder
Copy link
Collaborator

I've looked into this (and still am). The trouble is: there's multiple ways to implement this:

  • X-JABBER and co. support only one entry per vcard, roundcube expects backends to handle multiple entries per type.
  • IMPP is difficult to parse. It's not using the usual TYPE= parameter for distinguishing between different protocols, but instead used IMPP:jabber:a@jabb.com or IMPP:skype:blindcoder for this, which I have not yet found out how to realize with SabreDAVs VObject.

In the end, there's probably no "nice" way to do this.

@blind-coder
Copy link
Collaborator

I have pushed a branch issue_46 which tries to implement instant messenger types.
I've only tested it against Marten Gajdas carddav sync for android, so if you have other clients to test against, that would be great!

@bitbybit
Copy link
Author

Thank you. I also use CardDAV-Sync. For now it seems all data displayed correctly except "custom titles".

@blind-coder
Copy link
Collaborator

What do you mean by "custom titles"?

@bitbybit
Copy link
Author

Here is screenshots.
Phone titles: http://180upload.com/tacvy9t2jon9
IM titles: http://180upload.com/19uwk67bztr5 (instead of "Home" it must be "Google Talk")

@blind-coder
Copy link
Collaborator

Not sure where "Home" comes from, but roundcube doesn't support "Google Talk" as an option.
Right now, only Aim, ICQ, MSN, Yahoo, Jabber, Skype and Other are supported.
Can you post the relevant part of the .vcf for that contact?

@bitbybit
Copy link
Author

Yes, these titles/labels comes from CardDAV-Sync client, but Roundcube displays them correctly in the "Phone" section although RC itself does not support such titles/labels in adding/editing interface.

BEGIN:VCARD
VERSION:2.1
N;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:...;...;;;
FN;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:...
X-ANDROID-CUSTOM:vnd.android.cursor.item/nickname;...;1;;;;;;;;;;;;;
TEL;:+8...
TEL;X-free:+7...
TEL;HOME:+7...
TEL;:+7...
TEL;:+4...
TEL;:+7...
TEL;:+7...
ADR;HOME;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:;;;...;;...;...
ADR;HOME;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:;;...;...;;...;...
URL:...
URL:...
NOTE;CHARSET=UTF-8;ENCODING=QUOTED-PRINTABLE:...
BDAY:...
X-GOOGLE-TALK;HOME:...
END:VCARD

For some reason all TEL titles/labels are empty after export to VCF. As I see it, the option to add custom titles/labels to field is independent from actual type of field (TEL, ..., Aim, ICQ, MSN, ..., X-GOOGLE-TALK).

Here is screenshots from my smartphone:
http://180upload.com/tpft9wpxgq8y
http://180upload.com/zmjw5qm5nepj
http://180upload.com/930xi9x75ihs
http://180upload.com/1hug6va9cff2

@mstilkerich
Copy link
Owner

The Plugin supports custom labels via the X-AB-LABEL extension. New Labels cannot be created in roundcube but once a custom label has been seen it is available for selection. I guess the same extension is used for instant messenger properties and it should be straightforward to extend the use of the custom label support for those properties.

@mstilkerich
Copy link
Owner

Implemented on v4.1.

It's difficult to achieve interoperability with other clients, but I tried to make it as good as possible. See doc/devdoc/IMPP.md for some details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants