Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display name of company contacts ignored and overruled by organisation name #53

Closed
muggenhor opened this issue Aug 12, 2014 · 1 comment
Closed

display name of company contacts ignored and overruled by organisation name #53

muggenhor opened this issue Aug 12, 2014 · 1 comment
Milestone
4.1.0

Comments

@muggenhor
Copy link

The title says it all, but as an example a vcard to demonstrate:

BEGIN:VCARD
VERSION:3.0
UID:73c22b18-226a-11e4-85f9-00247e6a9a6c
ORG:IAK;Zorgverzekeringen
FN:IAK Zorgverzekeringen
TEL;TYPE=work:+31402611888
X-ABSHOWAS:COMPANY
END:VCARD

I'd expect to see the FN (display-name) being used as display name ("IAK Zorgverzekeringen"), this however gets overruled by the first component of the organisation name ("IAK"). This would probably be correct behaviour if no display name is present, it isn't however when one is present.
@mstilkerich mstilkerich added this to the 4.1.0 milestone Oct 31, 2020
mstilkerich added a commit that referenced this issue Nov 16, 2020
@mstilkerich
Only set displayname if empty (Fixes #53)
a483ca6 
It comes unexpected for users if the formatted name (FN) from a VCard is
overridden by RCMCardDAV because of the X-ABShowAs setting for an
organization. Lets assume that the FN attribute already contains the
intended value. The only situation where we now set a displayname when
parsing a VCard is if it has no FN or an empty FN.

In the other direction, it is also unexpected if a user explicitly sets
a displayname via the corresponding field in roundcube and RCMCardDAV
overrides it. Since we cannot distinguish a displayname composed by
roundcube from one explicitly entered by the user, we leave the
displayname alone except if it is not set.
@mstilkerich
Copy link
Owner

This is fixed on the v4.1 branch. It does not overrule FN anymore, and in the other direction it also does not overrule a displayname set by the user in roundcube or by roundcube itself (cannot distinguish the two cases). A displayname is now only composed if FN is not available/empty or if we receive no displayname from roundcube (when a contact is edited/created in the addressbook interface).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.0
Development

No branches or pull requests
2 participants
@muggenhor @mstilkerich