got rid of lenses

CHANGELOG.md

@@ -1,12 +1,6 @@
 Changelog
 =========
 
-Pending changes
----------------
-
-*   Added lenses `ixR`, `ixL`, `ixRow`, and `ixCol`, meant to be used with
-    `^^.` and `viewVar`.
-
 Version 0.1.0.0
 ---------------
 

README.md

@@ -16,9 +16,6 @@ re-exported.
 
 [static]: https://hackage.haskell.org/package/hmatrix-0.18.2.0/docs/Numeric-LinearAlgebra-Static.html
 
-Also includes a backpropagatable `sumElements`, and also lenses into *hmatrix*
-types meant to be used with `^^.` and `viewVar`.
-
 Formulas for gradients come from the following papers:
 
 *   <https://people.maths.ox.ac.uk/gilesm/files/NA-08-01.pdf>

src/Numeric/LinearAlgebra/Static/Backprop.hs

@@ -43,8 +43,7 @@
 -- functions are automatically backpropagatable.  Useful types are all
 -- re-exported.
 --
--- Also contains 'sumElements' 'BVar' operation, and lenses into hmatrix
--- types to use with '^^.' and 'viewVar'.
+-- Also contains 'sumElements' 'BVar' operation.
 --
 -- Formulas for gradients come from the following papers:
 --
@@ -178,15 +177,9 @@ module Numeric.LinearAlgebra.Static.Backprop (
   , mTm
   , unSym
   , (<·>)
-  -- * Lenses
-  , ixR
-  , ixL
-  , ixRow
-  , ixCol
   ) where
 
 import           Data.ANum
-import           Data.Finite
 import           Data.Maybe
 import           Data.Proxy
 import           Foreign.Storable
@@ -1211,34 +1204,3 @@ unSym = liftOp1 (opIso H.unSym unsafeCoerce)
 (<·>) = dot
 infixr 8 <·>
 {-# INLINE (<·>) #-}
-
---- | 'Lens' into an element of an /hmatrix/ vector.
---
--- @since 0.1.1.0
-ixR :: KnownNat n => Finite n -> Lens' (H.R n) H.ℝ
-ixR i f = fmap H.vecR . SVS.ix i f . H.rVec
-{-# INLINE ixR #-}
-
--- | 'Lens' into an element of an /hmatrix/ matrix.
---
--- @since 0.1.1.0
-ixL :: (KnownNat m, KnownNat n) => (Finite m, Finite n) -> Lens' (H.L m n) H.ℝ
-ixL (i,j) f (H.extract->v) = fromJust . H.create . go <$> f (v `HU.atIndex` ij)
-  where
-    ij = (fromIntegral i, fromIntegral j)
-    go x = HU.accum v const [(ij, x)]
-{-# INLINE ixL #-}
-
--- | 'Lens' into a row of an /hmatrix/ matrix.
---
--- @since 0.1.1.0
-ixRow :: KnownNat m => Finite m -> Lens' (H.L m n) (H.R n)
-ixRow i f = fmap H.rowsL . SV.ix i f . H.lRows
-{-# INLINE ixRow #-}
-
--- | 'Lens' into a column of an /hmatrix/ matrix.
---
--- @since 0.1.1.0
-ixCol :: KnownNat n => Finite n -> Lens' (H.L m n) (H.R m)
-ixCol i f = fmap H.colsL . SV.ix i f . H.lCols
-{-# INLINE ixCol #-}