Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only check remote is reachable when ttl timeout. #52

Merged
merged 1 commit into from
Jul 29, 2020
Merged

Only check remote is reachable when ttl timeout. #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
bin
coverage.txt
profile.out
.idea
12 changes: 8 additions & 4 deletions cache/cache.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,14 @@ func NewRepository(remote string, ttl time.Duration) (*Repository, error) {
if err != nil {
return nil, fmt.Errorf("ERROR: loading data from remote: %s", err)
}
} else if repo.isReachable() && (err != nil || info.ModTime().Before(time.Now().Add(-ttl))) {
err = repo.Reload()
if err != nil {
return nil, fmt.Errorf("ERROR: reloading cache: %s", err)
} else if err != nil || info.ModTime().Before(time.Now().Add(-ttl)) {
if repo.isReachable() {
err = repo.Reload()
if err != nil {
return nil, fmt.Errorf("ERROR: reloading cache: %s", err)
}
} else {
fmt.Errorf("INFO: remote is not reachable, reload skipped")
}
}

Expand Down