Add history function for the past page view. #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 62.70% 59.90% -2.80%
==========================================
Files 3 3
Lines 185 222 +37
==========================================
+ Hits 116 133 +17
- Misses 44 57 +13
- Partials 25 32 +7
Continue to review full report at Codecov.
|
mstruebing
reviewed
Sep 29, 2020
There was a problem hiding this comment.
Hey @wudong thank you very much for your PR 🚀
Sorry for the long delay, but I was busy with work and after that I didn't remembered this PR anymore.
Very good code and a cool feature, I just mentioned some minor changes, would be cool if you could make them happen.
|
Hi @mstruebing, all very valid points, thanks a lot. I have address the comments now. |
mstruebing
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Add history function into tldr.
Why I did it:
Often I want to review what I have searched, and to see if there are some information I should remember instead going back to tldr constantly. This history function keeps the history for what I have searched and allow me to review easily later.