Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Get port from Scheme #55

Merged
merged 1 commit into from
Sep 16, 2020
Merged

fix: Get port from Scheme #55

merged 1 commit into from
Sep 16, 2020

Conversation

mstruebing
Copy link
Owner

closes #54

What I did:

Why I did it:

@codecov-commenter
Copy link

Codecov Report

Merging #55 into master will decrease coverage by 1.65%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #55      +/-   ##
==========================================
- Coverage   62.70%   61.05%   -1.66%     
==========================================
  Files           3        3              
  Lines         185      190       +5     
==========================================
  Hits          116      116              
- Misses         44       49       +5     
  Partials       25       25              
Impacted Files Coverage Δ
cache/cache.go 51.42% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c123be...b924f76. Read the comment docs.

@mstruebing mstruebing merged commit 1689203 into master Sep 16, 2020
@mstruebing mstruebing deleted the fix/54/reachable branch October 5, 2023 05:49
@mstruebing mstruebing restored the fix/54/reachable branch October 5, 2023 05:49
@mstruebing mstruebing deleted the fix/54/reachable branch October 5, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repository.isReachable() doesn't work as expected
2 participants