Add Android platform; Import testify; Fix tests #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added Android to the list of available platorms, as it was breaking tests. I think this is the recent PR to tldr-pages that added Android: tldr-pages/tldr#5743 Also, I've imported the testify lib, as I'm using it extensively, and it just makes my life easier. :) https://github.com/stretchr/testify Finally, I refactored the TestAvailablePlatforms to table driven tests.
mstruebing
reviewed
Jun 20, 2021
mstruebing
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
TestAvailablePlatformsfunction to table driven tests.Why I did it:
testifyextensively in other projects, and it just makes my life way easier. :)