Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #66

Merged
merged 9 commits into from
Oct 10, 2023
Merged

GitHub actions #66

merged 9 commits into from
Oct 10, 2023

Conversation

AlexNDRmac
Copy link
Contributor

@AlexNDRmac AlexNDRmac commented Oct 7, 2023

What I did:

As I've asked about errors during test, so I've created workaround while you implementing changes to solve test issues.

What you need to change after fix the tests:

this

     - name: Run tests with coverage report
        run: |
            # Uncomment next line after fox tests
            # make test

            # and remove lines bellow after fixing tests
            echo "" > coverage.txt
            for d in $(go list ./... | grep -v vendor); do
                go test -race -coverprofile=profile.out -covermode=atomic -skip "TestRender|TestWrite|TestMarkdown" $d
                if [ -f profile.out ]; then
                    cat profile.out >> coverage.txt
                    rm profile.out
                fi
            done

change to this

     - name: Run tests with coverage report
        run: make test

@AlexNDRmac
Copy link
Contributor Author

@mstruebing please check PR. I've created workaround to avoid test fail. After fixes with tests - you can remove this workaround and use the full test suite.

Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
Signed-off-by: AlexNDRmac <alexndr.mac@gmail.com>
@mstruebing mstruebing merged commit 4d645bc into mstruebing:master Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants