Make showing commit message body in the revision graph optional (gite…

…xtensions#9301)
mstv · Jun 21, 2021 · 2c32e7e · 2c32e7e
1 parent d53de35
commit 2c32e7e
Show file tree

Hide file tree

Showing 7 changed files with 27 additions and 2 deletions.
diff --git a/GitCommands/Settings/AppSettings.cs b/GitCommands/Settings/AppSettings.cs
@@ -1259,6 +1259,12 @@ public static int RevisionGridQuickSearchTimeout
             set => SetInt("revisiongridquicksearchtimeout", value);
         }
 
+        public static bool ShowCommitBodyInRevisionGrid
+        {
+            get => GetBool("ShowCommitBodyInRevisionGrid", true);
+            set => SetBool("ShowCommitBodyInRevisionGrid", value);
+        }
+
         /// <summary>Gets or sets the path to the git application executable.</summary>
         public static string GitBinDir
         {

diff --git a/GitUI/CommandsDialogs/FormBrowse.cs b/GitUI/CommandsDialogs/FormBrowse.cs
@@ -849,7 +849,7 @@ private void RefreshSelection()
             FillCommitInfo(selectedRevision);
 
             // If the revision's body has been updated then the grid needs to be refreshed to display it
-            if (selectedRevision is not null && selectedRevision.HasMultiLineMessage && oldBody != selectedRevision.Body)
+            if (AppSettings.ShowCommitBodyInRevisionGrid && selectedRevision is not null && selectedRevision.HasMultiLineMessage && oldBody != selectedRevision.Body)
             {
                 RevisionGrid.Refresh();
             }

diff --git a/GitUI/Translation/English.xlf b/GitUI/Translation/English.xlf
@@ -8867,6 +8867,10 @@ See the changes in the commit form.</source>
         <source>Show build status text</source>
         <target />
       </trans-unit>
+      <trans-unit id="showCommitMessageBodyToolStripMenuItem.Text">
+        <source>Show commit message body</source>
+        <target />
+      </trans-unit>
       <trans-unit id="showDateColumnToolStripMenuItem.Text">
         <source>Show date column</source>
         <target />

diff --git a/GitUI/UserControls/RevisionGrid/Columns/MessageColumnProvider.cs b/GitUI/UserControls/RevisionGrid/Columns/MessageColumnProvider.cs
@@ -404,7 +404,7 @@ void DrawSuperProjectRef(string label, ref int currentOffset)
                 return;
             }
 
-            if (lines.Length > 1)
+            if (lines.Length > 1 && AppSettings.ShowCommitBodyInRevisionGrid)
             {
                 var commitBody = string.Concat(lines.Skip(1).Select(_ => " " + _));
                 var bodyBounds = messageBounds.ReduceLeft(offset);

diff --git a/GitUI/UserControls/RevisionGrid/RevisionGridControl.cs b/GitUI/UserControls/RevisionGrid/RevisionGridControl.cs
@@ -2185,6 +2185,13 @@ internal void ToggleShowMergeCommits()
             ForceRefreshRevisions();
         }
 
+        internal void ToggleShowCommitBodyInRevisionGrid()
+        {
+            AppSettings.ShowCommitBodyInRevisionGrid = !AppSettings.ShowCommitBodyInRevisionGrid;
+            MenuCommands.TriggerMenuChanged();
+            Refresh();
+        }
+
         internal void ShowFirstParent()
         {
             AppSettings.ShowFirstParent = !AppSettings.ShowFirstParent;

diff --git a/GitUI/UserControls/RevisionGrid/RevisionGridMenuCommands.cs b/GitUI/UserControls/RevisionGrid/RevisionGridMenuCommands.cs
@@ -354,6 +354,13 @@ private IReadOnlyList<MenuCommand> CreateViewMenuCommands()
                     ExecuteAction = () => _revisionGrid.ToggleShowGitNotes(),
                     IsCheckedFunc = () => AppSettings.ShowGitNotes
                 },
+                new MenuCommand
+                {
+                    Name = "showCommitMessageBodyToolStripMenuItem",
+                    Text = "Show commit message body",
+                    ExecuteAction = () => _revisionGrid.ToggleShowCommitBodyInRevisionGrid(),
+                    IsCheckedFunc = () => AppSettings.ShowCommitBodyInRevisionGrid
+                },
 
                 MenuCommand.CreateSeparator(),
 

diff --git a/contributors.txt b/contributors.txt
@@ -158,3 +158,4 @@ YYYY/MM/DD, github id, Full name, email
 2021/03/31, darkcamper, Rubén Ruiz, darkcamper(at)gmail.com
 2021/05/05, mrjithil, Jithil P Ponnan, jithil(at)outlook.com
 2021/05/07, dasiths, Dasith Wijesiriwardena, gitextensions.github(at)dasith.me
+2021/06/18, jwfx, Jörg Winkler, jwfx at bitmx.net