Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cross_reference items #3938

Open
4 tasks
clemens-msupply opened this issue May 19, 2024 · 3 comments
Open
4 tasks

Add support for cross_reference items #3938

clemens-msupply opened this issue May 19, 2024 · 3 comments
Labels
enhancement New feature or request Priority: Nice to Have These changes are not critical for the workflow to work
Milestone

Comments

@clemens-msupply
Copy link
Collaborator

clemens-msupply commented May 19, 2024

Legacy mSupply supports items of type cross_reference.

Cross references refer to alternate names for a certain item, for example, Acetylsalicylic Acid can also be known as Aspirin.

Also see for more information about cross references in mSupply:
https://docs.msupply.org.nz/items:adding_a_new_item?s[]=cross&s[]=reference#cross_reference_items

Describe the solution you'd like 🎁

Below tasks can be broken down into separate issues:

  • Sync through cross-reference items
  • Display these items for search in frontend
  • If a user selects an item from its alias then the normal item should be saved NOT the cross-reference item
  • The normal item name should be displayed not any alias it may go under

Describe alternatives you've considered 💭

Moneyworks Jobcode 🧰

@clemens-msupply clemens-msupply added enhancement New feature or request needs triage Team Tauhou Chris, Clemens, Roxy labels May 19, 2024
@roxy-dao roxy-dao added this to the V2.1.0 milestone May 22, 2024
@Chris-Petty
Copy link
Contributor

Chris-Petty commented May 29, 2024

https://github.com/msupply-foundation/msupply/issues/14726

As is being discussed there, the there was a bug resolved in mobile in 2018 where it had been treating cross reference items just like a normal item and some users used them like a normal item.

So the problem is a data issue, fortunately it seems to affect very few records across our users.

So this issue perhaps has two directions:

  1. Close, because the data will be resolved on the central server.
  2. Be rejigged into really "Supporting" cross reference items, that is to say add the functionality to see cross reference items in item selection lists, and when selected it selects the "referenced" item (e.g. "Panadol" -> "Paracetamol 500mg tablets"). Could be a new issue?

For the rust devs, it's mSupply's equivalent to aliasing a type 😉.

@mark-prins
Copy link
Collaborator

@jmbrunskill this may be useful for GAPS? the ability to have a cross-reference item for the Immunisation program

@roxy-dao roxy-dao added Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... Priority: Nice to Have These changes are not critical for the workflow to work and removed Epic Team Tauhou Chris, Clemens, Roxy Severity: Low Bugs that don't block workflows. UX like wrong fonts, bad layout... labels May 29, 2024
@roxy-dao
Copy link
Contributor

roxy-dao commented Jun 4, 2024

Setting to low priority. But @mark-prins will double check. Maybe to do with item variants?

@roxy-dao roxy-dao modified the milestones: V2.1.0, V2.2.0 Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority: Nice to Have These changes are not critical for the workflow to work
Projects
None yet
Development

No branches or pull requests

4 participants