Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line totals are not migrated properly #4273

Closed
nishaDangol-Sussol opened this issue Jun 25, 2024 · 7 comments · Fixed by #4346
Closed

Line totals are not migrated properly #4273

nishaDangol-Sussol opened this issue Jun 25, 2024 · 7 comments · Fixed by #4346
Assignees
Labels
bug Something is borken Build Tested: Passed Issue has been build tested with all tests passed. Migrate Existing Desktop Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Ruru 🦉 Carl, Andrei, Roxy Tester: Nisha
Milestone

Comments

@nishaDangol-Sussol
Copy link

What went wrong? 😲

Line totals are not migrated properly

Expected behaviour 🤔

Totals should be mapped correctly

How to Reproduce 🔨

Steps to reproduce the behaviour:

  1. Have a OG desktop site with line totals
  2. Migrate it to oms; i.e., reset hardware ID and reinitialise
  3. Login to oms
  4. Revisit those previous transacts with line totals
  5. See error: line totals is 0 despite the value. Also, notice that Foreign currency total. Looks weird to me.

image

Your environment 🌱

  • Open mSupply Version: v2.1.0-rc3
  • Legacy mSupply Central Server Version: v7-15-06
  • Platform:apk, browser(chrome)
  • Database type: sqlite
@nishaDangol-Sussol nishaDangol-Sussol added bug Something is borken needs triage Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release needs daily triage New bug to be triaged by the release team labels Jun 25, 2024
@roxy-dao
Copy link
Contributor

roxy-dao commented Jun 25, 2024

Currency total issue #3994. The totals are coming over just fine for me... can you give me the datafile you're using?

@nishaDangol-Sussol
Copy link
Author

nishaDangol-Sussol commented Jun 26, 2024

Currency total issue #3994. The totals are coming over just fine for me... can you give me the datafile you're using?

Sure, here's the link to the datafile. Credentials for test303 store-user: user: test3, pass:1234
image
image

@roxy-dao roxy-dao added Team Ruru 🦉 Carl, Andrei, Roxy and removed needs triage needs daily triage New bug to be triaged by the release team labels Jun 26, 2024
@roxy-dao roxy-dao self-assigned this Jun 26, 2024
@roxy-dao roxy-dao added this to the v2.1.0-rc4 milestone Jun 26, 2024
@roxy-dao
Copy link
Contributor

Currency total issue #3994. The totals are coming over just fine for me... can you give me the datafile you're using?

Can see it in the datafile you provided... did you do anything else?

I created a fresh datafile and created invoices with totals in OG then transferred to OMS site and totals are there 👀

@nishaDangol-Sussol
Copy link
Author

nishaDangol-Sussol commented Jun 27, 2024

Can see it in the datafile you provided... did you do anything else?

Nothing any specific, I was adding some tax values and multiple currencies previously. But in recent/newer transactions, I was creating just normal transactions

I created a fresh datafile and created invoices with totals in OG then transferred to OMS site and totals are there 👀

Ok, will retry with new datafile in rc4 and check

@nishaDangol-Sussol
Copy link
Author

nishaDangol-Sussol commented Jun 27, 2024

Ok, will retry with new datafile in rc4 and check

Tried with the new datafile (used Example datafile this time) in v2.1.0-rc4 and I still see the same results.
Totals from OG is not migrated properly when the same store is migrated to oms.

@mark-prins mark-prins self-assigned this Jul 2, 2024
@mark-prins mark-prins mentioned this issue Jul 2, 2024
4 tasks
@roxy-dao roxy-dao linked a pull request Jul 2, 2024 that will close this issue
4 tasks
@roxy-dao
Copy link
Contributor

roxy-dao commented Jul 2, 2024

Closed in #4346

@nishaDangol-Sussol
Copy link
Author

Tested in v2.1.0-rc6. Totals looks good now - PASS

@nishaDangol-Sussol nishaDangol-Sussol added the Build Tested: Passed Issue has been build tested with all tests passed. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Build Tested: Passed Issue has been build tested with all tests passed. Migrate Existing Desktop Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Ruru 🦉 Carl, Andrei, Roxy Tester: Nisha
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants