Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line totals migration #4346

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

mark-prins
Copy link
Collaborator

@mark-prins mark-prins commented Jul 2, 2024

Fixes #4273

πŸ‘©πŸ»β€πŸ’» What does this PR do?

The item_code was coming through, not as None but as an empty string.
I've handled the None and is_empty() as equivalent, and requiring calculation. Would be nice to have some sort of serde deserialize empty_as_none to handle this. surprised it hasn't come up before?

The result is this: the translation handles the new invoice as a new invoice and the pricing works:

image Screenshot 2024-07-02 at 12 42 51β€―PM

πŸ’Œ Any notes for the reviewer?

πŸ§ͺ Testing

πŸ“ƒ Documentation

  • Part of an epic: documentation will be completed for the feature as a whole
  • No documentation required: no user facing changes or a bug fix which isn't a change in behaviour
  • These areas should be updated or checked:
    1.
    2.

@github-actions github-actions bot added this to the v2.1.0-rc5 milestone Jul 2, 2024
@github-actions github-actions bot added bug Something is borken Migrate Existing Desktop Team Ruru πŸ¦‰ Andrei, Roxy, Chris, Ferg Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release labels Jul 2, 2024
@jmbrunskill jmbrunskill self-assigned this Jul 2, 2024
@roxy-dao roxy-dao linked an issue Jul 2, 2024 that may be closed by this pull request
Copy link
Contributor

@jmbrunskill jmbrunskill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm!

@roxy-dao roxy-dao merged commit a1d827f into release-v2.1.0 Jul 2, 2024
2 checks passed
@roxy-dao roxy-dao deleted the 4273-line-totals-migration branch July 2, 2024 05:32
@roxy-dao roxy-dao modified the milestones: v2.1.0-rc5, V2.1.0 Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Migrate Existing Desktop Severity: High Bugs breaking core functionality or with no/unacceptable workaround. High impact. Next patch release Team Ruru πŸ¦‰ Andrei, Roxy, Chris, Ferg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line totals are not migrated properly
3 participants