Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4273
π©π»βπ» What does this PR do?
The
item_code
was coming through, not asNone
but as an empty string.I've handled the
None
andis_empty()
as equivalent, and requiring calculation. Would be nice to have some sort of serde deserialize empty_as_none to handle this. surprised it hasn't come up before?The result is this: the translation handles the new invoice as a new invoice and the pricing works:
π Any notes for the reviewer?
π§ͺ Testing
test3
site and check outbound shipment Use url Search query params to determine sort, pagination and filter params on TablesΒ #2π Documentation
1.
2.