Tax displays incorrectly on totals below $1 in outbound shipments

[lache-melvin]

What went wrong? 😲

Seems fairly edge case (maybe less so for service charges?) but still a bit random...

If sub-total is less that $1, the tax percentage display gets confused - seems to show the whatever the tax value as a percentage, rather than the tax percentage?

In this case, I set tax to 50% for both the service charge and the items, which you can see the totals are calculated correctly, but the percentages are then 40% and 10%:

When you open the tax edit modal, it correctly shows 50 before refreshing the page, then it shows incorrectly (e.g. 10).

Expected behaviour 🤔

Tax percentage displays the tax percentage 👀

How to Reproduce 🔨

Steps to reproduce the behaviour:

1. Go to Outbound Shipment
2. Adds some items and/or service charges where total adds to less than a dollar
3. Add tax percentage
4. See tax percentage displayed is not the tax percentage you entered

Your environment 🌱

• Open mSupply Version: 2.1 RC
• Legacy mSupply Central Server Version:

• Platform:

• Database type:

[andreievg]

Triage, if it's just a front end bug then we can get it into 2.1, but if large problem then can be carried over to 2.2

[andreievg]

Related: #4281

[roxy-dao]

Closed in #4330

[regotaina]

🧪 Testing

• Create an outbound shipment

• Add lines with sell price less than $1

• Add tax

• Should calculate tax correctly

• Have service line in master list for store

• Add multiple service charges with different tax percentages

• Tax percentage and total should calculate correctly

[regotaina]

Passed the test 🥇