Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inbound shipment: tax percentage is being displayed as the tax value #4281

Open
lache-melvin opened this issue Jun 26, 2024 · 2 comments
Open
Labels
bug Something is borken Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. Team Ruru 馃 Lach茅, Carl, Andrei
Milestone

Comments

@lache-melvin
Copy link
Contributor

What went wrong? 馃槻

When tax is 10%, it shows as $10:

Screenshot 2024-06-26 at 1 53 10鈥疨M

Expected behaviour 馃

should show $30, not $10!

How to Reproduce 馃敤

Steps to reproduce the behaviour:

  1. create an Inbound shipment
  2. Add a line with a cost price per pack, so you end up with a stock total
  3. add tax to total
  4. See tax total is the percentage number, not the calculated amount of tax to pay!

Your environment 馃尡

  • Open mSupply Version: 2.1 RC3
  • Legacy mSupply Central Server Version:
  • Platform:
  • Database type:
@andreievg
Copy link
Collaborator

Triage, same as #4280:

@andreievg andreievg added Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. and removed needs triage labels Jun 27, 2024
@andreievg andreievg added this to the V2.1.0 milestone Jun 27, 2024
@andreievg andreievg added the Team Ruru 馃 Lach茅, Carl, Andrei label Jun 27, 2024
@mark-prins
Copy link
Collaborator

While looking at the inbound tax - would it be possible to add a % end adornment to the percentage input please?
I added a service charge and it isn't clear that the tax is a percentage in this modal:

Screenshot 2024-06-27 at 1 05 24鈥疨M

This one could do with a % as well:

Screenshot 2024-06-27 at 1 05 11鈥疨M

@roxy-dao roxy-dao modified the milestones: V2.1.0, v2.1.0-rc5 Jun 27, 2024
@lache-melvin lache-melvin removed the needs daily triage New bug to be triaged by the release team label Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is borken Severity: Normal Bugs which have an acceptable workaround. Moderate/tolerable user impact. Next minor release. Team Ruru 馃 Lach茅, Carl, Andrei
Projects
None yet
Development

No branches or pull requests

4 participants