WIP capslock light for USB connection #7
Conversation
This commit works mostly, however sometimes when the capslock led is enabled and the lighting controller was asleep it also turns on the backlighting effect, which is not correct. However I have yet to find a solution to this problem.
| if (IS_LED_ON(usb_led, USB_LED_CAPS_LOCK)) { | ||
| capslock_active = true; | ||
| /* Make sure the lighting chip is awake */ | ||
| anne_pro_lighting_on(); |
There was a problem hiding this comment.
Calling twice (or more while its already woke up) the awake command turns on the backlight,a possible solution its to track if mcu is already woke up.
There was a problem hiding this comment.
anne_pro_lighting_on() already checks if the lighting mcu is awake and skips the call if it is. However it looks like the problem is if the mcu is awoken and only the capslock is turned on and then it is put back to sleep, and awoken again, then it turns on the backlight.
There was a problem hiding this comment.
another bug, when lt is used instead of kc_caps, if backlight is on, led just does the opposite.
|
There are still problems with this code, therefore I'm currently closing this pull request. The changes in #5 have made some progress, but there are still weird edge cases. |
This commit works mostly, however sometimes when the capslock led is
enabled and the lighting controller was asleep it also turns on the
backlighting effect, which is not correct. However I have yet to find a
solution to this problem.
This is an alternative implementation to pull request #5.