Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wuerzburg: added "Mensateria" to existing wuerzburg parser #82

Merged
merged 2 commits into from
Aug 25, 2018

Conversation

pstiegele
Copy link
Contributor

In Würzburg has opened a new mensa. I added it to the existing parser, hope it works that way.

@klemens
Copy link
Collaborator

klemens commented Jul 28, 2018

Thank you for your contribution and sorry for talking so long.

I added it to the existing parser, hope it works that way.

Yes, that is the first step! 😉 It seems mensateria-campus-nord.html is now called (and redirected to) mensateria-campus-hubland-nord-wuerzburg.html. It seems to work fine with the existing parser based on my limited testing (although there is potential for general improvement of the parser).

I also noticed that there are some other changes in Würzburg:

  • burse-wuerzburg.html is now called burse-am-studentenhaus-wuerzburg.html
  • frankenstube-wuerzburg.html and mensa-am-hubland-wuerzburg.html don't exist anymore. Do you know more?
  • mensa-aschaffenburg is somehow missing the .html

If you want, you can add these changes to your pull request, otherwise I can also make them afterwards.

Edit:

There also seem to be two new canteens:

  • philosophie-wuerzburg.html
  • interimsmensa-im-sprachenzentrum-ab-9-april-2018.html Still relevant?

…, augenklinik, mensateria link. Added philo and sprachenzentrum interimsmensa, commented out hubland and frankenstube because they are being renovated the next years
@pstiegele
Copy link
Contributor Author

Hey, I updated the links. Frankenstube and Mensa am Hubland are closed for the next year 'cause of a renovation, that's why there are two new mensas.
Can't test it, but it should work.

@klemens klemens merged commit 3fd7e30 into mswart:master Aug 25, 2018
@klemens
Copy link
Collaborator

klemens commented Aug 25, 2018

Thanks, this is now merged! I also added a few changes to fix the parsing of prices and additives: c25be2e

It will probably take a little while before these changes are visible on openmensa.org.

@klemens
Copy link
Collaborator

klemens commented Feb 5, 2019

I just added the three new canteens, frankenstube and hubland were already disabled.

These should start working tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants