Uses dictionary structure to store records in the database

[kettanaito]

GitHub

• Closes Restructure database to a dictionary #3
• Based on feat: use dictionary instead of array #13

[kettanaito]

Hey, @marcosvega91. I've used your pull request (#13) to migrate to the dictionary. Sorry, I didn't want to bother you with a bunch of comments on the holiday's eve, I hope you don't mind that I rewrote this.

It's mostly the same with a few exceptions:

• Primary key is determined in parseModelDeclaration, so we don't have to do that twice.
• Primary key is required and we don't use a fallback to id. I find it a too presumptuous decision and would prefer the end developer to explicitly specify primary keys for their models.
• Primary key is stored in the internal entity properties, alongside __type and __nodeId.
• Model methods now use other model methods (i.e. delete uses findFirst and then deletes that found record).
• Querying by the primary key is done by applying the query on the temporary { [primaryKey]: keyValue } object, so we don't have to re-implement how compileQuery works for this use case.

If you have a minute I'd appreciate it if you gave these changes a review, as I'm not sure I've covered all the cases we've talked about. Thank you.

[kettanaito]

I have one question: with the introduction of the primary key it effectively becomes the __nodeId, doesn't it?

Should we still use an internal __nodeId, or should we now rely on __primaryKey? I wouldn't rework this now, but a thing to consider.

[marcosvega91]

it looks that all cases are covered here. About your question on node_id, I think that it can be removed. Good work 😄

[kettanaito]

Thank you for the work on this, @marcosvega91. This pull request wouldn't have been possible without yours.