Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/#203 support nullable nested objects #219

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feat/#203 support nullable nested objects #219

wants to merge 6 commits into from

Commits on May 22, 2022

  1. feat(modelvaluetype definition): extends ModelValueType definition to… 

    … accept 'Object' type

re mswjs#203
    Aloys Berger committed May 22, 2022
    Configuration menu
    Copy the full SHA
    72a0443 View commit details
    Browse the repository at this point in the history

  2. fix(modelvaluetype definition): review the ModelValueType definition … 

    …using exisiting type AnyObject

Change the definition of ModelValueType from 'Object' to 'AnyObject' (an existing type of the
library)

re 203
    Aloys Berger committed May 22, 2022
    Configuration menu
    Copy the full SHA
    2c9d39c View commit details
    Browse the repository at this point in the history

  3. test(nullable object): recreate issue scenario in the test 

    when using nullable<MyObject>( ... ), it is impossible to provide an object. It returns 'null' no
matter whether an object has been provided or not.

re 203
    Aloys Berger committed May 22, 2022
    Configuration menu
    Copy the full SHA
    9f9c1a6 View commit details
    Browse the repository at this point in the history

  4. fix(isprimitivevaluetype): cd '/Users/aloysberger/FOSS/data' 

    node 'node_modules/.bin/jest' '/Users/aloysberger/FOSS/data/test/model/create.test.ts' -c
'/Users/aloysberger/FOSS/data/test/jest.config.ts' -t 'supports nested nullable object' --runInBand

re mswjs#203
    Aloys Berger committed May 22, 2022
    Configuration menu
    Copy the full SHA
    6d19c2c View commit details
    Browse the repository at this point in the history

  5. test(update test nullable object): update tests for nested nullable o… 

    …bjects

Update tests to cover nested nullable objects

re mswjs#203
    Aloys Berger committed May 22, 2022
    Configuration menu
    Copy the full SHA
    d53d31c View commit details
    Browse the repository at this point in the history

  6. docs: update doc. to show an example of nullable nested objects in TS 

    re mswjs#203
    Aloys Berger committed May 22, 2022
    Configuration menu
    Copy the full SHA
    b72dace View commit details
    Browse the repository at this point in the history