Add generic type to getAll #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, getAll returned the type . Now, it correctly infers the type of the entities.
Closed
|
Looks I was a bit hasty to put up this PR. I was having some issues building/testing locally (fixed now), but it looks like there is a typing issue in the |
|
Hey, @camchenry. No worries. I've addressed the incompatibility of types and added a typings test case so we can catch regressions for this. Also made all the Database methods to accept the |
kettanaito
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
This is a superb addition. Thank you, @camchenry, and welcome to contributors!
Let us know if you'd like to tackle some other open issues. We'd appreciate your feedback on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, getAll returned the type
any[], even though it returned additional properties. Now, the entity type is correctly inferred (similar tofindFirst,findMany, etc.).