fix: ensure request body input is always a string #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Aug 9, 2022
kettanaito
commented
- Fixes Doesn't work when used with "express.json" middleware #18
- Fixes Incoming request body has been parsed as [object Object] #17
kettanaito
commented
Aug 9, 2022
| const mockedRequest = new MockedRequest( | ||
| // Treat all relative URLs as the ones coming from the server. | ||
| new URL(req.url, serverOrigin), | ||
| { | ||
| method: req.method, | ||
| headers: new Headers(req.headers as HeadersInit), | ||
| credentials: 'omit', | ||
| body: encodeBuffer(req.body), | ||
| body: encodeBuffer(requestBody), |
There was a problem hiding this comment.
With msw@0.44, the input for the body is always an ArrayBuffer that encodes a plain string. Previously, it was possible passing a plain object as well, that's why the issue surfaced only now.
Released: v0.5.1 🎉This has been released in v0.5.1! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.