Skip to content

Commit

Permalink
chore: use "httpServer" namespace consistently (#174)
Browse files Browse the repository at this point in the history
  • Loading branch information
kettanaito committed Nov 9, 2021
1 parent 2e7ce32 commit ede3126
Show file tree
Hide file tree
Showing 18 changed files with 178 additions and 136 deletions.
14 changes: 7 additions & 7 deletions test/compliance/XMLHttpRequest/events-order.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { createXMLHttpRequest } from '../../helpers'

type EventPool = [string, number][]

let server: ServerApi
let httpServer: ServerApi
const interceptor = createInterceptor({
modules: [interceptXMLHttpRequest],
resolver(request) {
Expand Down Expand Up @@ -44,7 +44,7 @@ function spyOnEvents(request: XMLHttpRequest, pool: EventPool) {
}

beforeAll(async () => {
server = await createServer((app) => {
httpServer = await createServer((app) => {
app.get('/', (req, res) => {
res.status(200).end()
})
Expand All @@ -59,14 +59,14 @@ afterEach(() => {
})

afterAll(async () => {
await server.close()
await httpServer.close()
})

test('emits correct events sequence for an unhandled request with no response body', async () => {
interceptor.apply()
const mockEvents: EventPool = []
const request = await createXMLHttpRequest((request) => {
request.open('GET', server.http.makeUrl())
request.open('GET', httpServer.http.makeUrl())
spyOnEvents(request, mockEvents)
})

Expand All @@ -90,7 +90,7 @@ test('emits correct events sequence for a handled request with no response body'
interceptor.apply()
const mockEvents: EventPool = []
const request = await createXMLHttpRequest((request) => {
request.open('GET', server.http.makeUrl('/user'))
request.open('GET', httpServer.http.makeUrl('/user'))
spyOnEvents(request, mockEvents)
})

Expand All @@ -108,7 +108,7 @@ test('emits correct events sequence for an unhandled request with a response bod
interceptor.apply()
const mockEvents: EventPool = []
const request = await createXMLHttpRequest((request) => {
request.open('GET', server.http.makeUrl('/numbers'))
request.open('GET', httpServer.http.makeUrl('/numbers'))
spyOnEvents(request, mockEvents)
})

Expand All @@ -132,7 +132,7 @@ test('emits correct events sequence for a handled request with a response body',
interceptor.apply()
const mockEvents: EventPool = []
const request = await createXMLHttpRequest((request) => {
request.open('GET', server.http.makeUrl('/numbers-mock'))
request.open('GET', httpServer.http.makeUrl('/numbers-mock'))
spyOnEvents(request, mockEvents)
})

Expand Down
8 changes: 4 additions & 4 deletions test/compliance/XMLHttpRequest/request-headers.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { createInterceptor } from '../../../src'
import { interceptXMLHttpRequest } from '../../../src/interceptors/XMLHttpRequest'
import { createXMLHttpRequest } from '../../helpers'

let server: ServerApi
let httpServer: ServerApi
let rawRequestHeaders: string[]

const interceptor = createInterceptor({
Expand All @@ -19,7 +19,7 @@ beforeAll(async () => {

// Handle the request in an actual server
// to inspect the raw request headers.
server = await createServer((app) => {
httpServer = await createServer((app) => {
app.get('/', (req, res) => {
rawRequestHeaders = req.rawHeaders
res.status(200).end()
Expand All @@ -29,12 +29,12 @@ beforeAll(async () => {

afterAll(async () => {
interceptor.restore()
await server.close()
await httpServer.close()
})

test('request headers casing', async () => {
await createXMLHttpRequest((req) => {
req.open('GET', server.http.makeUrl('/'))
req.open('GET', httpServer.http.makeUrl('/'))
req.setRequestHeader('X-Custom-Token', 'abc-123')
})

Expand Down
14 changes: 7 additions & 7 deletions test/events/request.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { interceptClientRequest } from '../../src/interceptors/ClientRequest'
import { createXMLHttpRequest, httpRequest } from '../helpers'

let requests: IsomorphicRequest[] = []
let server: ServerApi
let httpServer: ServerApi
const interceptor = createInterceptor({
modules: [interceptClientRequest, interceptXMLHttpRequest],
resolver() {},
Expand All @@ -20,7 +20,7 @@ interceptor.on('request', (request) => {
})

beforeAll(async () => {
server = await createServer((app) => {
httpServer = await createServer((app) => {
app.post('/user', (req, res) => {
res.status(201).end()
})
Expand All @@ -35,12 +35,12 @@ afterEach(() => {

afterAll(async () => {
interceptor.restore()
await server.close()
await httpServer.close()
})

it('ClientRequest: emits the "request" event upon the request', (done) => {
const request = http.request(
server.http.makeUrl('/user'),
httpServer.http.makeUrl('/user'),
{
method: 'POST',
headers: {
Expand All @@ -52,7 +52,7 @@ it('ClientRequest: emits the "request" event upon the request', (done) => {
const [request] = requests

expect(request.method).toEqual('POST')
expect(request.url.href).toEqual(server.http.makeUrl('/user'))
expect(request.url.href).toEqual(httpServer.http.makeUrl('/user'))
expect(request.headers.get('content-type')).toEqual('application/json')
expect(request.body).toEqual(JSON.stringify({ userId: 'abc-123' }))
done()
Expand All @@ -64,7 +64,7 @@ it('ClientRequest: emits the "request" event upon the request', (done) => {

it('XMLHttpRequest: emits the "request" event upon the request', async () => {
await createXMLHttpRequest((request) => {
request.open('POST', server.http.makeUrl('/user'))
request.open('POST', httpServer.http.makeUrl('/user'))
request.setRequestHeader('Content-Type', 'application/json')
request.send(JSON.stringify({ userId: 'abc-123' }))
})
Expand All @@ -79,7 +79,7 @@ it('XMLHttpRequest: emits the "request" event upon the request', async () => {

const [request] = requests
expect(request.method).toEqual('POST')
expect(request.url.href).toEqual(server.http.makeUrl('/user'))
expect(request.url.href).toEqual(httpServer.http.makeUrl('/user'))
expect(request.headers.get('content-type')).toEqual('application/json')
expect(request.body).toEqual(
JSON.stringify({
Expand Down
12 changes: 6 additions & 6 deletions test/integrations/got.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import { ServerApi, createServer } from '@open-draft/test-server'
import { createInterceptor } from '../../src'
import { interceptClientRequest } from '../../src/interceptors/ClientRequest'

let server: ServerApi
let httpServer: ServerApi
const interceptor = createInterceptor({
modules: [interceptClientRequest],
resolver(request) {
if (request.url.toString() === server.http.makeUrl('/test')) {
if (request.url.toString() === httpServer.http.makeUrl('/test')) {
return {
status: 200,
body: 'mocked-body',
Expand All @@ -20,7 +20,7 @@ const interceptor = createInterceptor({
})

beforeAll(async () => {
server = await createServer((app) => {
httpServer = await createServer((app) => {
app.get('/user', (req, res) => {
return res.status(200).json({ id: 1 })
})
Expand All @@ -31,18 +31,18 @@ beforeAll(async () => {

afterAll(async () => {
interceptor.restore()
await server.close()
await httpServer.close()
})

test('mocks response to a request made with "got"', async () => {
const res = await got(server.http.makeUrl('/test'))
const res = await got(httpServer.http.makeUrl('/test'))

expect(res.statusCode).toBe(200)
expect(res.body).toBe('mocked-body')
})

test('bypasses an unhandled request made with "got"', async () => {
const res = await got(server.http.makeUrl('/user'))
const res = await got(httpServer.http.makeUrl('/user'))

expect(res.statusCode).toBe(200)
expect(res.body).toEqual(`{"id":1}`)
Expand Down

0 comments on commit ede3126

Please sign in to comment.