Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XMLHttpRequest: "onload" is called twice #359

Closed
kettanaito opened this issue Mar 3, 2023 · 1 comment · Fixed by #360
Closed

XMLHttpRequest: "onload" is called twice #359

kettanaito opened this issue Mar 3, 2023 · 1 comment · Fixed by #360

Comments

@kettanaito
Copy link
Member

Looks like a recent fix of on* callback setters (propagating them as events) resulted in two listeners being added for a single callback assigned.
This was referenced Mar 3, 2023
Merged
Merged
kettanaito added a commit that referenced this issue Mar 4, 2023
@kettanaito
fix(XMLHttpRequest): prevent event handlers from being called twice (#…
313f8ca 
…360)

- Fixes #359

I still have 0 idea why JSDOM doesn't fire its setter for `onload`. It
doesn't even have one. Narrowing down the workaround to concern itself
only with `ontimeout`. All other event handlers seem to be working
correctly (added tests).
@kettanaito
Copy link
Member Author

Released: v0.22.6 🎉

This has been released in v0.22.6!

Make sure to always update to the latest version (npm i @mswjs/interceptors@latest) to get the newest features and bug fixes.

Predictable release automation by @ossjs/release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(XMLHttpRequest): prevent event handlers from being called twice mswjs/interceptors
1 participant
@kettanaito