fix(ClientRequest): throw when writing after end for bypass responses

src/interceptors/ClientRequest/NodeClientRequest.ts

@@ -20,6 +20,7 @@ import { toInteractiveRequest } from '../../utils/toInteractiveRequest'
 import { uuidv4 } from '../../utils/uuid'
 import { emitAsync } from '../../utils/emitAsync'
 import { getRawFetchHeaders } from '../../utils/getRawFetchHeaders'
+import { NodeError } from '../../utils/nodeError'
 
 export type Protocol = 'http' | 'https'
 
@@ -104,6 +105,13 @@ export class NodeClientRequest extends ClientRequest {
   }
 
   write(...args: ClientRequestWriteArgs): boolean {
+    if (this.isRequestSent) {
+      const err = new NodeError('write after end', 'ERR_STREAM_WRITE_AFTER_END')
+      process.nextTick(() => this.emit('error', err))
+
+      return false
+    }
+
     const [chunk, encoding, callback] = normalizeClientRequestWriteArgs(args)
     this.logger.info('write:', { chunk, encoding, callback })
     this.chunks.push({ chunk, encoding })

src/utils/nodeError.ts

@@ -0,0 +1,5 @@
+export class NodeError extends Error {
+  constructor(message: string, readonly code: string) {
+    super(message)
+  }
+}

test/modules/http/compliance/http-req-end-then-write.test.ts

@@ -0,0 +1,40 @@
+import { it, expect, beforeAll, afterAll } from 'vitest'
+import http from 'http'
+import express from 'express'
+import { HttpServer } from '@open-draft/test-server/http'
+import { DeferredPromise } from '@open-draft/deferred-promise'
+import { ClientRequestInterceptor } from '../../../../src/interceptors/ClientRequest'
+
+const httpServer = new HttpServer((app) => {
+  app.post('/resource', express.text({ type: '*/*' }), (req, res) => {
+    res.send(req.body)
+  })
+})
+
+const interceptor = new ClientRequestInterceptor()
+
+beforeAll(async () => {
+  interceptor.apply()
+  await httpServer.listen()
+})
+
+afterAll(async () => {
+  interceptor.dispose()
+  await httpServer.close()
+})
+
+it('emits the ERR_STREAM_WRITE_AFTER_END error when write after end given no mocked response', async () => {
+  const req = http.request(httpServer.http.url('/resource'))
+
+  const errorReceived = new DeferredPromise<NodeJS.ErrnoException>()
+  req.on('error', (error) => {
+    errorReceived.resolve(error)
+  })
+
+  req.end()
+  req.write('foo')
+
+  const error = await errorReceived
+
+  expect(error.code).toBe('ERR_STREAM_WRITE_AFTER_END')
+})