feat: add experimental loaders #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/mswjs/msw-storybook-addon/AprRarRc3rZ9bnib3TY7t9nG4FZT |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSW is currently used in a decorator in this addon, however that has a limitation: The handlers are used only during the render cycle of the component. If you were to try and use this addon with Storybook loaders, which execute before of the rendering of the component, it wouldn't be possible to mock those requests.
This PR introduces an experimental
mswLoader, which allows for requests to be mocked before the component renders.For now we should just experiment with it, but there is a possibility this should be the way to go, as registering the handlers before the render cycle will make sure there's no chance for flake.