-
-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "[MSW] Mocking disabled." console message #485
Comments
Hey, @yairkukielka. Thanks for the suggestion. Would you be interested in creating a pull request with this improvement? It should be a matter of adding the log as a part of msw/src/setupWorker/stop/createStop.ts Lines 9 to 13 in 8a5f573
In the case of the msw/src/setupWorker/start/utils/activateMocking.ts Lines 10 to 14 in 8a5f573
|
@kettanaito I'd love to work on it as you suggested in Discord, seems also like a great way for me to get a bit more familiar with the repo 💕 |
That'd be awesome, @tigerabrodi! If you don't mind, I've assigned this issue to you, so others know somebody's taking care of it. Looking forward to our discussion on the code review. |
@kettanaito Defo, no worries, thanks for the opportunity 🥰 |
Would currently get this console message when MSW is enabled:
[MSW] Mocking enabled.
It would be great to add the
[MSW] Mocking disabled.
when it's disabled.My use case:
I'm building a small web app to mesure the performance of a web library. I'm mocking backend calls with MSW. I added a checkbox that can be used to toggle activation, deactivation of the mocking and it would be great to have confirmation in the console with this message.
Thank you!
The text was updated successfully, but these errors were encountered: