Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print console message when calling "worker.stop()" #493

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Print console message when calling "worker.stop()" #493

merged 1 commit into from
Jan 16, 2021

Conversation

tigerabrodi
Copy link
Contributor

This closes #485 馃憤 馃帀 馃挴

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 5, 2020 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 93842bb:

Sandbox Source
MSW React Configuration

kettanaito
kettanaito requested changes Dec 5, 2020
View reviewed changes
src/setupWorker/stop/createStop.ts Outdated Show resolved Hide resolved
src/setupWorker/stop/createStop.ts Outdated Show resolved Hide resolved
@kettanaito
Copy link
Member

Thank you for this improvement, @tigerabrodi! I've left a few comments, I'd appreciate if you had a look at them.

@tigerabrodi tigerabrodi marked this pull request as draft December 5, 2020 20:00
@tigerabrodi
Copy link
Contributor Author

This PR is set to Draft, how we gonna implement this is still under planning/thinking. 馃憤

@kettanaito
Copy link
Member

I'll try to finalize this in the upcoming days. Once more thank you for the superb work.

@kettanaito kettanaito force-pushed the add-mocking-disabled-log branch 2 times, most recently from 467b1ee to 867af69 Compare January 14, 2021 13:48
@kettanaito
Copy link
Member

I've polished things a little and added an integration test. Looks good, let's wait for the CI.

kettanaito
kettanaito previously approved these changes Jan 14, 2021
View reviewed changes
@kettanaito
Copy link
Member

Welcome to the contributors, @tigerabrodi 馃帀 Happy to see you joining.

@kettanaito kettanaito changed the title feat(createStop): add console.groupCollapsed if msw is disabled Print console message when calling "worker.stop()" Jan 14, 2021
@kettanaito kettanaito marked this pull request as ready for review January 14, 2021 13:56
@kettanaito
Copy link
Member

Strange CI issue of failing test/msw-api/setup-worker/stop/quiet.test.ts test. I've re-run it multiple times locally and everything passes.

@kettanaito kettanaito merged commit 507ff7e into mswjs:master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timdeschryver timdeschryver timdeschryver left review comments

@kettanaito kettanaito kettanaito approved these changes

Assignees
No one assigned
Labels
release candidate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "[MSW] Mocking disabled." console message
3 participants
@tigerabrodi @kettanaito @timdeschryver