Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use ESM-friendly mirrors of "statuses" and "js-levenshtein" #1603

Merged
merged 1 commit into from
Apr 29, 2023

Conversation

thepassle
Copy link
Contributor

Tests pass:

image

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f35fd2:

Sandbox Source
MSW React Configuration

@thepassle thepassle mentioned this pull request Apr 29, 2023
34 tasks
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look fantastic. Thank you so much for all the help with ESM, @thepassle.

I've left a comment about annotating the default export of statuses. That should be possible, I think.

}

declare module '@bundled-es-modules/statuses' {
const source_default: any
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's annotate this export? Just to be safe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add these type definitions, we're already depending on @types/statuses.

@kettanaito kettanaito changed the title fix: esm fixes fix: use ESM-friendly mirrors of "statuses" and "js-levenshtein" Apr 29, 2023
@kettanaito kettanaito merged commit 0f35fd2 into mswjs:feat/standard-api Apr 29, 2023
9 of 10 checks passed
@kettanaito
Copy link
Member

I've pushed to the remote and since it pointed to the same branch (just on fork), GitHub decided to merge this pull request. All's good though, the changes are great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants