fix: stream response chunks as they come in Node.js #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 641fea7:
|
kettanaito
commented
May 3, 2023
| // Ensure that the chunks were sent over time, | ||
| // respecting the delay set in the mocked stream. | ||
| const chunkTimings = chunks.map((chunk) => chunk.timestamp) | ||
| expect(chunkTimings[1] - chunkTimings[0]).toBeGreaterThanOrEqual(500) |
There was a problem hiding this comment.
This will fail at the moment because the Interceptors used to consume the entire response stream before setting the this.res = response and emitting the response event on the ClientRequest instance.
That's no longer the case with the fix.
kettanaito
changed the title
kettanaito
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs the Interceptors dependency bump to have the newly added tests pass.