feat(worker): move exception handling from the worker #1734
Conversation
kettanaito
commented
Sep 12, 2023
kettanaito
commented
- Closes Move request error message from the worker to the main thread #1683
|
Hey, @thepassle 👋 I'm following up on our discussion in #1683 to remove the error handling from the worker. Could you give this change a try to see if it works as expected? Thanks. |
| @@ -87,7 +87,6 @@ self.addEventListener('message', async function (event) { | |||
|
|
|||
| self.addEventListener('fetch', function (event) { | |||
| const { request } = event | |||
| const accept = request.headers.get('accept') || '' | |||
There was a problem hiding this comment.
Unused accept variable.
Oh great, thanks! In which rc version is this? |
|
@thepassle, it's not released anywhere yet as I need to check some local tests. You can try it out from the PR directly. |
|
Tried this out locally, this seems to work fine for me :) LGTM 👍 |
|
Thank you! I will look into the tests that timeout locally for me for some reason and get this merged sometime this week. |
