feat: support throwing responses in response resolvers #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kettanaito
commented
Jan 13, 2024
kettanaito
commented
- Closes Support throwing Response in resolvers #1690
kettanaito
commented
Jan 13, 2024
| ...resolverExtras, | ||
| request: args.request, | ||
| }) as Promise<Response> | ||
| ).catch((errorOrResponse) => { |
There was a problem hiding this comment.
I'm adding this on the lowest level possible for two reasons:
- This way all handlers get this behavior, no matter if the
handleRequestis run in the browser or Node context; - This way even the direct users of the
RequestHandlerget this behavior, which is essential.
kettanaito
force-pushed
the
feat/throw-response
branch
from
6ac199b
to
497bb78
Compare
kettanaito
changed the title
Released: v2.1.0 🎉This has been released in v2.1.0! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.