fix: resolve "~/core" import for .d.mts modules #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kettanaito
changed the title
kettanaito
force-pushed
the
chore/patch-mjs-dts
branch
2 times, most recently
from
cadb795
to
1283fb3
Compare
kettanaito
force-pushed
the
chore/patch-mjs-dts
branch
from
1283fb3
to
855ac0b
Compare
Released: v2.2.7 🎉This has been released in v2.2.7! Make sure to always update to the latest version ( Predictable release automation by @ossjs/release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a custom script that resolves the
~/corein the import paths in.d.tsfiles (since those won't resolve). But we miss to do that for.d.mtsfiles, which leaves them broken.Also added two layers of protection to prevent this issue in the future:
grepfor any~/corein the resolved.d.{ts,mts}modules;tscrun on all the.d.{ts,mts}modules to make sure they compile.