Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify params getter #54

Merged
merged 2 commits into from Mar 5, 2020
Merged

Simplify params getter #54

merged 2 commits into from Mar 5, 2020

Conversation

hehehai
Copy link
Contributor

@hehehai hehehai commented Mar 5, 2020

#47

@kettanaito
Copy link
Member

Hi, @hehehai. Thanks for one more pull request!

kettanaito
kettanaito approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@kettanaito kettanaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you for the improvement!

@kettanaito kettanaito merged commit adc16e9 into mswjs:master Mar 5, 2020
@kettanaito kettanaito mentioned this pull request Mar 5, 2020
Closed
@hehehai hehehai deleted the simplify-params-getter branch March 12, 2020 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kettanaito kettanaito kettanaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hehehai @kettanaito