Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates "headers-utils" to 2.0 #648

Closed
wants to merge 2 commits into from
Closed

Updates "headers-utils" to 2.0 #648

wants to merge 2 commits into from

Conversation

kettanaito
Copy link
Member

@kettanaito kettanaito commented Mar 13, 2021 •
edited

  • Includes the Headers.forEach() callback arguments order fix.
  • Ensures the Headers polyfill is compatible with the standard window.Headers class (adds iterators).

@kettanaito
Copy link
Member Author

Once this version is rolled out to NRI and page-with, this dependency will get deduped.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 13, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21be02b:

Sandbox Source
MSW React Configuration

@kettanaito kettanaito added the dependencies Pull requests that update a dependency file label Mar 13, 2021
@kettanaito kettanaito mentioned this pull request Mar 14, 2021
Closed
@kettanaito
Copy link
Member Author

CI is failing due to mswjs/headers-polyfill#9.

@kettanaito kettanaito changed the title Updates "headers-utils" to 1.2.5 Updates "headers-utils" to 2.0 Mar 15, 2021
@kettanaito
Copy link
Member Author

The trailing space at the end of the header values needs NRI update to propagate the fix.

@kettanaito kettanaito marked this pull request as draft March 19, 2021 14:39
@kettanaito kettanaito mentioned this pull request Mar 23, 2021
Merged
@kettanaito
Copy link
Member Author

Closing in favor of #660.

@kettanaito kettanaito closed this Mar 23, 2021
@kettanaito kettanaito deleted the deps-headers-utils-1.2.5 branch March 23, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kettanaito