Externalize @mswjs/* packages in certain builds

[patrickmcdougle-okta]

PR mentioned in #660 (comment)

Maybe fixes: #905

More work to be added possibly: #851 (comment) (which would likely fix #912) Not doing this here.

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 401e68c:

Sandbox	Source
MSW React	Configuration

[patrickmcdougle-okta]

Let me know if you need me to clean up the history (squash) and / or let me know if you want me to handle the debug dependency problem in this body of work as well.

Thanks!

[kettanaito]

Hey, @patrickmcdougle-okta. Thank you for preparing this, the changes look great!

I've had a few comments and would like to know your opinion. I think this is almost ready to go, just a few things left. Looking forward to releasing this!

Regarding the debug issue, let's address it in a separate pull request. I feel it may involve some changes in the biuld process of the interceptors library.

[patrickmcdougle-okta]

Sorry for the delay, I was off yesterday. I'll make the proposed changes today. Thanks for your patience and your review!

[patrickmcdougle-okta]

I rebased to pull in the current tip of master, but kept a separate new commit for easy reviewing. Let me know if you need me to squash anything.

[kettanaito]

The current CI fails on the init integration test:

> msw@0.35.0 postinstall /root/release/tmp/auto-update-worker/node_modules/msw
> node -e "try{require('./config/scripts/postinstall')}catch(e){}"

/root/release/tmp/auto-update-worker/node_modules/inquirer/lib/prompts/rawlist.js:126
      this.selected = this.selected ?? -1;
                                     ^

SyntaxError: Unexpected token '?'
    at wrapSafe (internal/modules/cjs/loader.js:1054:16)
    at Module._compile (internal/modules/cjs/loader.js:1102:27)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1158:10)
    at Module.load (internal/modules/cjs/loader.js:986:32)
    at Function.Module._load (internal/modules/cjs/loader.js:879:14)
    at Module.require (internal/modules/cjs/loader.js:1026:19)
    at require (internal/modules/cjs/helpers.js:72:18)
    at Function.promptModule.restoreDefaultPrompts (/root/release/tmp/auto-update-worker/node_modules/inquirer/lib/inquirer.js:65:36)
    at Object.inquirer.createPromptModule (/root/release/tmp/auto-update-worker/node_modules/inquirer/lib/inquirer.js:72:16)
    at Object.<anonymous> (/root/release/tmp/auto-update-worker/node_modules/inquirer/lib/inquirer.js:84:28)

Seems related to #916.

Edit: You can ignore this failure, it won't happen anymore. The issue was fixed by the underlying dependency that introduced it in the first place.

[patrickmcdougle-okta]

I rebased again to pull in the current tip of master, but kept another separate commit for easy reviewing. Let me know if you need me to squash anything.

[kettanaito]

Thank you for this improvement, @patrickmcdougle-okta!

Collaborating with you on this was great. Let me know if you are interested in helping us with the project, there are always some tasks to work on.

Meanwhile, let’s have this one merged.

[patrickmcdougle-okta]

Sorry to bother on a closed PR...Will there be a release with this code included soon? It fixes a bug I'm seeing in a product I'm building and I'd like to avoid maintaining a fork.

[kettanaito]

No worries. I'd like to include a few more bug fixes in the next release. There's no ETA, but I was planning on releasing the next version somewhere in October.

[misha-erm]

+1 for releasing this. I can't use msw right now because of it.

I described my use-case here #796 (comment)

Thanks in advance

[msutkowski]

@patrickmcdougle-okta @MikeYermolayev I'd recommend using the CSB build until the next release if you're in a bind. If you weren't aware, you can install as shown here: https://ci.codesandbox.io/status/mswjs/msw/pr/913/builds/169956