Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easier install #5

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

illeatmyhat
Copy link

@illeatmyhat illeatmyhat commented Jul 29, 2021

Part of #2
This PR primarily focuses on providing a docker container that generally works, and makes the code as platform independent as possible with ROCm and CPU fallback.
Because requirements.txt was not installable as is, libraries were also updated, and deprecated functions replaced.

Particularly, those using VS Code and have Development Containers set up should be able to just open the folder and have a correctly running environment.

Caveats

  1. PyTorch has no support for GPUs on Macs whatsoever.
  2. CPU inference jobs are sometimes Killed in Docker because of additional memory overhead that tends to exceed the capacity of a Mac.
  3. The output is distorted, maybe because of breaking changes in nn.Upsample and imresize()

shegreat_0020

@illeatmyhat illeatmyhat changed the title Easer install Easier install Jul 29, 2021
@TsXor
Copy link

TsXor commented Oct 8, 2022

I don't know if you have used that maybe well-known DeepCreamPy, but your symptom looks relatively like "color bleeding".
In DeepCreamPy, marking the region you want to inpaint with brush tool, which almost always have anti-aliasing will cause such "color bleeding".
Look into this link for details: https://github.com/liaoxiong3x/DeepCreamPy/blob/master/TROUBLESHOOTING.md#strange-color-decensors

@TsXor
Copy link

TsXor commented Oct 8, 2022

According to the paper, you can output of every subroutine to locate the problem:

  • ScreenVAE encoded map -> ScreenVAE Encoder network
  • inpainted ScreenVAE map -> Semantic Inpainting network
  • inpainted lines -> Semantic Inpainting network
  • all the 3 above have no exception -> Appearance Synthesis network.

If the problem is really color bleeding, the exceptions should have happened in Semantic Inpainting network, and inpainted lines and ScreenVAE map should be abnormal.
What's more, you mentioned imresize(), and in another implementation by this author, he used ANTIALIAS param in imresize(), and as mentioned above, color bleeding is almost always caused by anti-aliasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants