-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify sys.winver
to match upstream
#68
Modify sys.winver
to match upstream
#68
Conversation
4250015
to
1af22cd
Compare
4260a10
to
fac1fc9
Compare
sys.winver
to include 32 for i686 buildssys.winver
to match upstream
6f06dae
to
1351254
Compare
Traceback (most recent call last):
File "D:\a\cpython-mingw\cpython-mingw\mingw_smoketests.py", line 78, in test_sysconfig_schemes
self.assertEqual(dist_path, sys_path, (scheme, name))
AssertionError: 'C:/Users/runneradmin/.local/include/python3.10' != 'C:/Users/runneradmin/.local/include/python3.10-mingw_x86_64'
- C:/Users/runneradmin/.local/include/python3.10
+ C:/Users/runneradmin/.local/include/python3.10-mingw_x86_64
? +++++++++++++
: ('nt_user', 'include') Hmm, wondering where distutils save this path? Do you know @lazka? |
uh, one more thing to change in distutils :( or to rip out of distutils :) |
4b19930
to
96fa967
Compare
2ec630b
to
026dba0
Compare
cpython-mingw/.github/workflows/mingw.yml Line 119 in 2ea5fa3
also, probably not related to this PR, but cpython-mingw/.github/workflows/mingw.yml Line 123 in 2ea5fa3
doesn't match, the shebang doesn't contain ${pkgdir}
|
|
I'm making a new PR with 026dba0 |
Not related to this PR (even happens on 3.9), opened #79 |
With this change `sys.winver` will add the Arch for which python was compiled on, for example in 32-bits, `sys.winver` will be `3.10-32`, for arm32 it would be `3.10-arm32` and so on. See msys2-contrib#40
026dba0
to
53d4c31
Compare
This should avoid mixing of user site-packages between python from various environments. Previously, the user site-packages should be located at `~/.local/lib/python3.10` for all environment including 32-bits variants which caused problems with 64-bit trying to load 32-bit extensions. Now this path will be changed to `~/.local/lib/python3.10-<platform tag here>`, for example, in CLANG64 this would be `~/.local/lib/python3.10-mingw_x86_64_clang`. Fixes msys2-contrib#40
53d4c31
to
f03d544
Compare
I have made 5ee18ec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I wonder if avoiding sysconfig is worth it here |
It does make a bit of a difference. Though we would have to move _POSIX_BUILD too. For another PR... If someone is interested -> |
Also, fixes #40
Does this looks good to you @lazka?