-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build venvlauncher.exe from PC/launcher.c #82
Build venvlauncher.exe from PC/launcher.c #82
Conversation
60fb715
to
38fc8e4
Compare
3fa0e22
to
d3fff52
Compare
59b1d0b
to
5ec5076
Compare
Also, fix warnings in PC/pylauncher.rc
_wdupenv_s -> _wgetenv_s fread_s -> fread
5ec5076
to
321c323
Compare
these tests that are failing are broken on the |
lgtm! |
(note that on #85 mingw32 is failing for some reason, not sure if that is relevant for this) |
Yeah, not sure why though. I'll just merge this and deploy it so that people can test. |
add patches from msys2-contrib/cpython-mingw#82
I think we can't find it out here because the tests itself doesn't pass for the smoke tests to be run when installed. I think static linking on mingw32 is broken (maybe)? Should I make an issue in MINGW-packages repo about that? |
Let's update the package so we can test it out |
No, it isn't broken. Actually, the program executes outside of the virtual env without anything in PATH, so I think that error is only when the actual python interpreter is launched. I'm wondering why it happens only on mingw32 though. |
Also, this would mean this doesn't happen if python is installed in
Though I'm still wondering how it works on mingw64. |
Fixes #16