Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build venvlauncher.exe from PC/launcher.c #82

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

naveen521kk
Copy link
Member

Fixes #16

@naveen521kk naveen521kk marked this pull request as draft January 29, 2022 12:25
@naveen521kk naveen521kk force-pushed the fix-venv-3.10 branch 3 times, most recently from 3fa0e22 to d3fff52 Compare January 31, 2022 06:56
@naveen521kk naveen521kk marked this pull request as ready for review March 8, 2022 16:36
@naveen521kk naveen521kk marked this pull request as draft March 9, 2022 06:22
@naveen521kk naveen521kk mentioned this pull request Mar 13, 2022
8 tasks
@naveen521kk naveen521kk changed the base branch from mingw-v3.10.0 to mingw-v3.10.2 March 13, 2022 16:37
@naveen521kk naveen521kk marked this pull request as ready for review March 13, 2022 16:50
@naveen521kk
Copy link
Member Author

naveen521kk commented Mar 18, 2022

these tests that are failing are broken on the mingw-v3.10.2 branch, so this PR didn't cause that. I think I'll just merge this. @lazka does this look good to you?

@lazka
Copy link
Member

lazka commented Mar 18, 2022

lgtm!

@lazka
Copy link
Member

lazka commented Mar 18, 2022

(note that on #85 mingw32 is failing for some reason, not sure if that is relevant for this)

@naveen521kk
Copy link
Member Author

(note that on #85 mingw32 is failing for some reason, not sure if that is relevant for this)

Yeah, not sure why though. I'll just merge this and deploy it so that people can test.

@naveen521kk naveen521kk merged commit 1a4e816 into msys2-contrib:mingw-v3.10.2 Mar 18, 2022
@naveen521kk naveen521kk deleted the fix-venv-3.10 branch March 18, 2022 15:20
naveen521kk added a commit to naveen521kk/MINGW-packages that referenced this pull request Mar 18, 2022
@naveen521kk
Copy link
Member Author

naveen521kk commented Mar 18, 2022

(note that on #85 mingw32 is failing for some reason, not sure if that is relevant for this)

Yeah, not sure why though. I'll just merge this and deploy it so that people can test.

I think we can't find it out here because the tests itself doesn't pass for the smoke tests to be run when installed. I think static linking on mingw32 is broken (maybe)? Should I make an issue in MINGW-packages repo about that?

@lazka
Copy link
Member

lazka commented Mar 18, 2022

Let's update the package so we can test it out

@naveen521kk
Copy link
Member Author

I think static linking on mingw32 is broken (maybe)? Should I make an issue in MINGW-packages repo about that?

No, it isn't broken. Actually, the program executes outside of the virtual env without anything in PATH, so I think that error is only when the actual python interpreter is launched. I'm wondering why it happens only on mingw32 though.

@naveen521kk
Copy link
Member Author

I think static linking on mingw32 is broken (maybe)? Should I make an issue in MINGW-packages repo about that?

No, it isn't broken. Actually, the program executes outside of the virtual env without anything in PATH, so I think that error is only when the actual python interpreter is launched. I'm wondering why it happens only on mingw32 though.

Also, this would mean this doesn't happen if python is installed in /mingw32/bin, since it should contain those GCC DLLs. Setting the launcher to debug mode (using PYLAUNCH_DEBUG env var), I could see this print

launcher build: 32bit
launcher executable: Console
File 'C:\dev\temp-test\mingw32\bin\.venv\bin\pyvenv.cfg' non-existent
Using venv configuration file 'C:\dev\temp-test\mingw32\bin\.venv\pyvenv.cfg'
Called with command line:
run_child: about to run 'C:/dev/temp-test/mingw32/bin\python.exe'
child process exit code: -1073741515

Though I'm still wondering how it works on mingw64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants