ag grepper: New package #730

forgottenswitch · 2016-10-28T20:00:45Z

"A better grep" and an addon package.
Distributions name it the_silver_searcher.

Chocobo1 · 2016-10-29T05:52:05Z

ag/PKGBUILD

@@ -0,0 +1,33 @@
+# Maintainer: Mihail Konev <k.mvc@ya.ru>


IMO this folder should be named ag-git.
There should be another folder ag which installs stable release version.

The same applies to cgvg.

Chocobo1 · 2016-10-29T05:59:37Z

ag/PKGBUILD

+
+pkgname=ag
+srcname=the_silver_searcher
+pkgver=git


A fixed pkgver disables the ability to update this package (via pacman) in the future.
See https://aur.archlinux.org/packages/?O=0&K=-git for a better pkgver scheme.

Also if you have time:
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packages/the_silver_searcher
https://wiki.archlinux.org/index.php/Arch_packaging_standards
https://wiki.archlinux.org/index.php/PKGBUILD

mati865 · 2016-10-29T17:34:55Z

pkgver is wrong. For git packages it should use commit number like here https://github.com/Alexpux/MSYS2-packages/blob/master/gyp-git/PKGBUILD

The gettext package must be supplying the /usr/bin/gettext, while libintl should be enough for gettext().

mati865 · 2016-10-31T09:21:41Z

pkgver is still wrong, look here: https://github.com/Alexpux/MSYS2-packages/blob/master/gyp-git/PKGBUILD#L24

mati865 · 2016-10-31T09:23:53Z

ag-git/PKGBUILD

+url="https://github.com/ggreer/the_silver_searcher"
+groups=('base' 'base-devel')
+provides=('ag')
+conflicts=('ag')


Remove provides=('ag'), conflicts=('ag') and groups=('base' 'base-devel')

https://github.com/Alexpux/MSYS2-packages/blob/master/mintty-git/PKGBUILD#L11

It was package() in cgvg that was failing.

mati865 · 2016-10-31T09:27:10Z

ag-git/PKGBUILD

@@ -0,0 +1,35 @@
+# Maintainer: Mihail Konev <k.mvc@ya.ru>
+
+pkgname=ag


change pkgname=ag to pkgname=ag-git

mati865 · 2016-10-31T09:27:41Z

cgvg-git/PKGBUILD

@@ -0,0 +1,29 @@
+# Maintainer: Mihail Konev <k.mvc@ya.ru>
+
+pkgname=cgvg


change pkgname=cgvg to pkgname=cgvg-git

mati865 · 2016-10-31T09:28:23Z

cgvg-git/PKGBUILD

+url="https://github.com/forgottenswitch/cgvg"
+groups=('base' 'base-devel')
+provides=('cgvg')
+conflicts=('cgvg')


remove groups=('base' 'base-devel'), provides=('cgvg'), conflicts=('cgvg')

forgottenswitch · 2016-11-04T04:09:42Z

The cgvg is also implemented here, having profiles concept (but no manpage):
https://github.com/sampson-chen/sack

mingwandroid · 2016-11-04T08:18:33Z

We already have ag in MINGW-packages so I'm against adding it here too. This came up already about a year ago.

mingwandroid · 2016-11-07T23:53:34Z

The named pipe issue can be fixed with some tests for the pipe names. Git for Windows does this.

Slightly related, until the pipe handling is fixed, to prevent MINGW-packages ag from thinking it's in pipe mode pass . as an argument to indicate the current working directory.

forgottenswitch · 2016-11-08T01:09:22Z

Put this into header and patch ag, nodejs, ffmpeg, everything stdout is not a tty?
https://github.com/git-for-windows/git/pull/102/commits

Also:

[msys2-runtime]$ ag "[-]pty"
winsup/cygwin/fhandler_tty.cc
516:      __small_sprintf (buf, "\\\\.\\pipe\\cygwin-%S-pty%d-master-ctl",
1299:     __small_sprintf (buf, "\\\\.\\pipe\\cygwin-%S-pty%d-master-ctl",
1700:  __small_sprintf (buf, "\\\\.\\pipe\\cygwin-%S-pty%d-master-ctl",

mingwandroid · 2016-11-08T01:22:08Z

Yes, but we need to be careful of licenses. @kblees, would you consider relicensing this code under BSD so we can use it in GPL and BSD software in MSYS2? If not then we'll need to rewrite it.

mingwandroid · 2016-11-08T01:25:10Z

Sure.

forgottenswitch · 2016-11-08T04:13:25Z

Minimal working example:
https://github.com/forgottenswitch/mingw-isatty

This also pulls ntdll.dll, as well as headers

forgottenswitch changed the title ~~Ag grepper~~ ag grepper: New package Oct 28, 2016

forgottenswitch added 2 commits October 29, 2016 05:50

ag: New package (the_silver_searcher)

79e0a06

cgvg: New package

d7238aa

Chocobo1 reviewed Oct 29, 2016

View reviewed changes

forgottenswitch added 6 commits October 29, 2016 21:20

ag: rename as -git

9b715be

cgvg: rename as -git

8f9d1b9

ag: fix license

7af67d7

ag: fix deps

4bd36c3

ag: fix pkgrel

4864e51

cgvg: fix pkgrel

eb303e3

forgottenswitch added 4 commits October 30, 2016 01:22

ag: fix gettext -> libintl

ac16dbd

The gettext package must be supplying the /usr/bin/gettext, while libintl should be enough for gettext().

cgvg: update depends

35eff97

ag: add missing provides/conflicts

544da2b

cgvg: add missing provides/conflicts

eb1ece9

mati865 suggested changes Oct 31, 2016

View reviewed changes

forgottenswitch added 5 commits November 1, 2016 16:49

ag,cgvg: fix pkgname

150b85b

ag,cgvg: remove groups

f7ac22c

ag,cgvg: fix pkgver

4f75fa9

cgvg: fix build

a6dbb1f

ag,cgvg: quote urls

f9c7a0f

forgottenswitch closed this Nov 4, 2016

forgottenswitch deleted the ag branch November 4, 2016 11:59

forgottenswitch mentioned this pull request Nov 9, 2016

Fix "stdin is not a tty" Alexpux/mingw-w64#3

Closed

k-takata mentioned this pull request Jun 5, 2017

ag: Update to 2.0.0 and support detecting mintty msys2/MINGW-packages#2555

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ag grepper: New package #730

ag grepper: New package #730

forgottenswitch commented Oct 28, 2016 •

edited

Chocobo1 Oct 29, 2016

Chocobo1 Oct 29, 2016

mati865 commented Oct 29, 2016

mati865 commented Oct 31, 2016

mati865 Oct 31, 2016

forgottenswitch Nov 1, 2016

forgottenswitch Nov 1, 2016

mati865 Oct 31, 2016

mati865 Oct 31, 2016

mati865 Oct 31, 2016

forgottenswitch commented Nov 4, 2016 •

edited

mingwandroid commented Nov 4, 2016

mingwandroid commented Nov 7, 2016

forgottenswitch commented Nov 8, 2016 •

edited

mingwandroid commented Nov 8, 2016

mingwandroid commented Nov 8, 2016

forgottenswitch commented Nov 8, 2016 •

edited

		@@ -0,0 +1,35 @@
		# Maintainer: Mihail Konev <k.mvc@ya.ru>

		pkgname=ag

		@@ -0,0 +1,29 @@
		# Maintainer: Mihail Konev <k.mvc@ya.ru>

		pkgname=cgvg

ag grepper: New package #730

ag grepper: New package #730

Conversation

forgottenswitch commented Oct 28, 2016 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mati865 commented Oct 29, 2016

mati865 commented Oct 31, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

forgottenswitch commented Nov 4, 2016 • edited

mingwandroid commented Nov 4, 2016

mingwandroid commented Nov 7, 2016

forgottenswitch commented Nov 8, 2016 • edited

mingwandroid commented Nov 8, 2016

mingwandroid commented Nov 8, 2016

forgottenswitch commented Nov 8, 2016 • edited

forgottenswitch commented Oct 28, 2016 •

edited

forgottenswitch commented Nov 4, 2016 •

edited

forgottenswitch commented Nov 8, 2016 •

edited

forgottenswitch commented Nov 8, 2016 •

edited